309 lines
9.7 KiB
Python
309 lines
9.7 KiB
Python
"""Closed grammar, scalar resolution, disclosure, and refusal tests."""
|
|
|
|
import pytest
|
|
from pydantic import ValidationError
|
|
|
|
from riff_groove_builder.description import (
|
|
DescriptionConflictError,
|
|
resolve_description,
|
|
)
|
|
from riff_groove_builder.errors import InvalidRequestError, UnsupportedDescriptionError
|
|
from riff_groove_builder.schemas import GenerateMusicRequest, Part
|
|
|
|
|
|
def request(description: str, **kwargs: object) -> GenerateMusicRequest:
|
|
return GenerateMusicRequest.model_validate(
|
|
{"description": description, "basename": "description", **kwargs}
|
|
)
|
|
|
|
|
|
def test_defaults_and_disclosures() -> None:
|
|
resolved = resolve_description(request("Please create simple music."))
|
|
intent = resolved.intent
|
|
assert intent.parts == ["lead", "bass", "drums"]
|
|
assert (intent.tempo_bpm, intent.bars, intent.key, intent.seed) == (120, 4, "E minor", 0)
|
|
assert intent.time_signature.model_dump() == {"numerator": 4, "denominator": 4}
|
|
assert intent.rhythm_terms == ["eighth", "rock", "no_rests"]
|
|
assert intent.techniques == ["normal"]
|
|
assert len(resolved.assumptions) == 9
|
|
assert resolved.overrides == []
|
|
assert {line.split(":")[0] for line in resolved.assumptions} == {
|
|
"tempo_bpm",
|
|
"bars",
|
|
"key",
|
|
"time_signature",
|
|
"parts",
|
|
"subdivision",
|
|
"template",
|
|
"rests",
|
|
"technique",
|
|
}
|
|
|
|
|
|
def test_text_case_spacing_and_enharmonic_normalization() -> None:
|
|
resolved = resolve_description(
|
|
request(
|
|
" GENERATE\tGUITAR, bass AND DRUMS at 137.5 BPM, 3 bars in 7 / 8, "
|
|
"bB MAJOR, straight sixteenth-notes with rests, metal, SUSTAIN! "
|
|
)
|
|
)
|
|
intent = resolved.intent
|
|
assert intent.parts == ["lead", "bass", "drums"]
|
|
assert (intent.tempo_bpm, intent.bars, intent.key) == (137.5, 3, "A# major")
|
|
assert intent.time_signature.model_dump() == {"numerator": 7, "denominator": 8}
|
|
assert intent.rhythm_terms == ["sixteenth", "metal", "rests"]
|
|
assert intent.techniques == ["normal"]
|
|
assert not resolved.assumptions
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("text", "parts"),
|
|
[
|
|
("lead", ["lead"]),
|
|
("guitar only", ["lead"]),
|
|
("riff", ["lead"]),
|
|
("bass riff", ["bass"]),
|
|
("bass groove", ["bass"]),
|
|
("drum groove", ["drums"]),
|
|
("bass guitar", ["bass"]),
|
|
("bass guitar riff", ["bass"]),
|
|
("bass guitar groove only", ["bass"]),
|
|
("only bass and drums", ["bass", "drums"]),
|
|
("drums, lead guitar and bass", ["lead", "bass", "drums"]),
|
|
("lead and bass only, without drums", ["lead", "bass"]),
|
|
("no drums", ["lead", "bass"]),
|
|
("without bass and drums", ["lead"]),
|
|
("exclude lead, bass", ["drums"]),
|
|
("lead, no drums", ["lead"]),
|
|
("bass + guitar", ["lead", "bass"]),
|
|
],
|
|
)
|
|
def test_part_selection(text: str, parts: list[Part]) -> None:
|
|
assert resolve_description(request(text)).intent.parts == parts
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"text",
|
|
["lead no lead", "bass only, lead", "only bass and only drums", "no lead, bass and drums"],
|
|
)
|
|
def test_conflicting_or_empty_part_selections(text: str) -> None:
|
|
with pytest.raises(UnsupportedDescriptionError):
|
|
resolve_description(request(text))
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("text", "field"),
|
|
[
|
|
("120 BPM and 121 BPM", "tempo_bpm"),
|
|
("slow fast", "tempo_bpm"),
|
|
("fast 120 bpm", "tempo_bpm"),
|
|
("4 bars 3 bars", "bars"),
|
|
("in 4/4 and 7/8", "time_signature"),
|
|
("E minor C major", "key"),
|
|
("quarter eighth", "subdivision"),
|
|
("rock metal", "template"),
|
|
("rests no rests", "rests"),
|
|
("normal palm mute", "technique"),
|
|
],
|
|
)
|
|
def test_conflicts_have_actionable_fields(text: str, field: str) -> None:
|
|
with pytest.raises(DescriptionConflictError) as caught:
|
|
resolve_description(request(text))
|
|
assert caught.value.details == {"reason": "contradictory_text", "field": field}
|
|
|
|
|
|
def test_repeated_equivalent_values_are_not_conflicts() -> None:
|
|
resolved = resolve_description(
|
|
request("120 BPM 120.0 bpm 4 bars 4 bars 4/4 4/4 Bb major A# major lead normal sustain")
|
|
)
|
|
assert resolved.intent.key == "A# major"
|
|
assert resolved.intent.parts == ["lead"]
|
|
|
|
|
|
def test_all_structured_overrides_win_even_over_contradictory_text() -> None:
|
|
resolved = resolve_description(
|
|
request(
|
|
"120 bpm 140 bpm slow 4 bars 2 bars 4/4 7/8 E minor C major lead no lead bass only",
|
|
tempo_bpm=90.5,
|
|
bars=6,
|
|
time_signature={"numerator": 3, "denominator": 4},
|
|
key="Db major",
|
|
parts=["drums", "bass"],
|
|
seed=123,
|
|
)
|
|
)
|
|
intent = resolved.intent
|
|
assert (intent.tempo_bpm, intent.bars, intent.key, intent.seed) == (90.5, 6, "C# major", 123)
|
|
assert intent.parts == ["drums", "bass"]
|
|
assert intent.time_signature.numerator == 3
|
|
assert len(resolved.overrides) == 5
|
|
assert all("structured" in record and "text" in record for record in resolved.overrides)
|
|
assert len(resolved.assumptions) == 4
|
|
assert resolved == resolve_description(
|
|
request(
|
|
"120 bpm 140 bpm slow 4 bars 2 bars 4/4 7/8 E minor C major lead no lead bass only",
|
|
tempo_bpm=90.5,
|
|
bars=6,
|
|
time_signature={"numerator": 3, "denominator": 4},
|
|
key="Db major",
|
|
parts=["drums", "bass"],
|
|
seed=123,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(("text", "tempo"), [("slow riff", 80), ("fast rock", 160)])
|
|
def test_qualitative_tempo_is_a_fixed_policy(text: str, tempo: int) -> None:
|
|
assert resolve_description(request(text)).intent.tempo_bpm == tempo
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"text",
|
|
[
|
|
"piano",
|
|
"violin",
|
|
"keyboard",
|
|
"leader",
|
|
"bassoon",
|
|
"drumstick",
|
|
"leadership",
|
|
"C dorian",
|
|
"A harmonic minor",
|
|
"E blues",
|
|
"F# lydian",
|
|
"lead swing",
|
|
"lead triplets",
|
|
"lead polyrhythm",
|
|
"guitar 3 against 4",
|
|
"lead audio",
|
|
"lead wav",
|
|
"record guitar",
|
|
"lead hammer on",
|
|
"guitar legato",
|
|
"bass slap",
|
|
"lead slide",
|
|
"guitar bend",
|
|
"guitar vibrato",
|
|
"guitar tremolo",
|
|
"no palm mute lead",
|
|
"not drums",
|
|
"lead without distortion",
|
|
"lead chorus",
|
|
"lead 120 bpm then 140 bpm",
|
|
"lead tempo changes 120 bpm",
|
|
"lead 120 bpm to 140 bpm",
|
|
"accelerando guitar",
|
|
"lead slow down",
|
|
"please",
|
|
"!!!",
|
|
"lead 1/2 bars",
|
|
"lead 120/2 bpm",
|
|
"lead 120e2 bpm",
|
|
"lead 4.0.0 bars",
|
|
"lead 4//4",
|
|
"lead 4/4/4",
|
|
"lead 4/4bars",
|
|
"lead eclips",
|
|
"bass ray",
|
|
"drums sd3",
|
|
"lead E minor with piano",
|
|
],
|
|
)
|
|
def test_unknown_material_never_disappears(text: str) -> None:
|
|
with pytest.raises(UnsupportedDescriptionError):
|
|
resolve_description(request(text))
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"text",
|
|
[
|
|
"lead 19 bpm",
|
|
"lead 301 bpm",
|
|
"lead -120 bpm",
|
|
"lead 0 bpm",
|
|
"lead 0 bars",
|
|
"lead 257 bars",
|
|
"lead -1 bars",
|
|
"lead 1.5 bars",
|
|
"lead 0/4",
|
|
"lead 17/4",
|
|
"lead 4/3",
|
|
"lead 4/0",
|
|
"lead 3/32",
|
|
],
|
|
)
|
|
def test_text_bounds_are_named_errors(text: str) -> None:
|
|
with pytest.raises(UnsupportedDescriptionError):
|
|
resolve_description(request(text))
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"text",
|
|
[
|
|
"20 bpm 1 bar 1/16 C major",
|
|
"300 bpm 256 bars 16/1 Cb minor",
|
|
"+120.25 bpm 2 bars 6/8 F# minor",
|
|
],
|
|
)
|
|
def test_text_boundaries(text: str) -> None:
|
|
resolve_description(request(text))
|
|
|
|
|
|
@pytest.mark.parametrize("text", ["", " ", "x" * 4001])
|
|
def test_invalid_descriptions_fail_existing_contract(text: str) -> None:
|
|
with pytest.raises(ValidationError):
|
|
request(text)
|
|
|
|
|
|
def test_mutated_request_revalidated() -> None:
|
|
value = request("lead")
|
|
value.description = ""
|
|
with pytest.raises(InvalidRequestError):
|
|
resolve_description(value)
|
|
|
|
|
|
def test_overrides_do_not_authorize_unknown_material_or_tempo_changes() -> None:
|
|
for text in ("piano", "C dorian", "120 bpm then 140 bpm"):
|
|
with pytest.raises(UnsupportedDescriptionError):
|
|
resolve_description(request(text, tempo_bpm=120, key="E minor", parts=["lead"]))
|
|
|
|
|
|
def test_palm_mute_canonical_phrase_is_retained_for_profile_validation() -> None:
|
|
for text in ("palm mute guitar", "palm-muted bass", "palm muted riff"):
|
|
assert resolve_description(request(text)).intent.techniques == ["palm_mute"]
|
|
|
|
|
|
def test_extreme_numeric_text_is_bounded_without_float_overflow() -> None:
|
|
with pytest.raises(UnsupportedDescriptionError):
|
|
resolve_description(request("9" * 3500 + " BPM"))
|
|
assert resolve_description(request("9" * 3500 + " BPM", tempo_bpm=120)).intent.tempo_bpm == 120
|
|
|
|
|
|
def test_structured_override_without_text_is_disclosed_not_an_assumption() -> None:
|
|
resolved = resolve_description(
|
|
request(
|
|
"music",
|
|
parts=["bass"],
|
|
tempo_bpm=20,
|
|
bars=256,
|
|
time_signature={"numerator": 1, "denominator": 16},
|
|
key="Cb minor",
|
|
)
|
|
)
|
|
assert len(resolved.overrides) == 5
|
|
assert len(resolved.assumptions) == 4
|
|
|
|
|
|
def test_structured_override_can_replace_out_of_bounds_scalar_text() -> None:
|
|
resolved = resolve_description(
|
|
request(
|
|
"lead 999 bpm 999 bars in 99/3",
|
|
tempo_bpm=120,
|
|
bars=4,
|
|
time_signature={"numerator": 4, "denominator": 4},
|
|
)
|
|
)
|
|
assert resolved.intent.tempo_bpm == 120
|
|
assert resolved.intent.bars == 4
|
|
assert resolved.intent.time_signature.numerator == 4
|