286 lines
17 KiB
Markdown
286 lines
17 KiB
Markdown
```
|
|
# Step-02A Worker Report
|
|
|
|
## Status
|
|
|
|
**COMPLETE** for the assigned worker implementation and verification. Both
|
|
corrections, regressions, documentation, complete Release build/test suites and
|
|
native Windows smoke checks are finished. Manual orchestrator acceptance of
|
|
Step-02/Step-02A remains pending. Step-03 was not started.
|
|
|
|
## Objective and scope
|
|
|
|
Corrected only the Step-02A findings:
|
|
|
|
- R-01: timestamp import previously accepted incomplete and ambient-dependent
|
|
date/time forms.
|
|
- R-02: null optional evidence identity fields were incorrectly treated as
|
|
assertions that the corresponding target module identities were also null.
|
|
|
|
The existing seven-project modular monolith, Client/UI/Components ownership,
|
|
Core/Application feature boundaries, real DI, `/vehicle-profiles` UI, catalog
|
|
atomicity, exact revision selection and metadata-only safety boundary remain.
|
|
No new executable, assembly, project reference, package, persistence layer,
|
|
external service or vehicle-operation capability was added.
|
|
|
|
## R-01 root cause and fix
|
|
|
|
`VehicleProfileJsonCodec.NullableDate` used `DateTimeOffset.TryParse` with
|
|
InvariantCulture and RoundtripKind. That parser could supply today's date for
|
|
time-only values, use the machine-local zone when the offset was absent, and
|
|
accept whitespace/culture forms outside the v1 timestamp contract. The previous
|
|
generic failure text also did not describe the required complete input.
|
|
|
|
The replacement parser first matches a strict ASCII lexical form and then parses
|
|
the date/time portion with `DateTime.TryParseExact`, invariant culture and
|
|
`DateTimeStyles.None`. It validates the explicit suffix itself and constructs
|
|
`DateTimeOffset` from the exact parsed wall time and supplied offset; no current
|
|
date, local time-zone default or assumption style is used. Invalid calendar,
|
|
offset and representability values fail as a typed
|
|
`VehicleProfileInterchangeException`.
|
|
|
|
Accepted values are explicit JSON null or exactly:
|
|
`YYYY-MM-DDTHH:mm:ss[.fraction](Z|+HH:mm|-HH:mm)`.
|
|
The four-digit Gregorian date, uppercase `T`, hours/minutes/seconds and explicit
|
|
offset are required. The optional decimal fraction has 1-7 ASCII digits.
|
|
Offsets are whole-minute values within -14:00 through +14:00. No surrounding
|
|
whitespace, date-only/time-only, missing seconds/year/offset, slash/culture
|
|
dates, malformed calendar dates, invalid offsets or extra fractional precision
|
|
are accepted. The JSON error identifies the exact `publishedAt` or `retrievedAt`
|
|
path. Existing round-trip export remains unchanged.
|
|
|
|
## R-02 root cause and fix
|
|
|
|
`VehicleProfile.ValidateEvidenceReferences` used `SameOptional` for each of the
|
|
four module-scoped hardware/software/firmware/calibration applicability values.
|
|
The helper required a null evidence constraint to match a null module value,
|
|
rejecting an otherwise valid module-scoped record whenever it omitted a known
|
|
module identity.
|
|
|
|
The shared helper now interprets null on the evidence side as no constraint.
|
|
Every supplied non-null value still must match a known target module value using
|
|
ordinal case-insensitive comparison. A mismatch or any supplied value targeting
|
|
an unknown module identity is rejected. Nothing is copied into the evidence or
|
|
module, inferred, promoted or authorized. A module-scoped evidence record can
|
|
omit all four optional identity constraints. Version-specific constraints still
|
|
require an explicit module ID. The same profile validation is used for direct
|
|
constructors and imported profiles, including both module and capability
|
|
evidence references; vehicle/profile/revision/model-year/reference checks remain.
|
|
|
|
## Before-fix reproductions
|
|
|
|
The tests were added and run against the original Step-02 implementation before
|
|
either correction:
|
|
|
|
- `dotnet test .\src\tests\AutoForge.UnitTests\AutoForge.UnitTests.csproj --configuration Release --no-restore --filter FullyQualifiedName~VehicleProfileJsonCodecTests`
|
|
exited 1: 18 failed, 19 passed, 0 skipped, 37 total. The failures included
|
|
accepted date-only, offset-free, time-only and whitespace-padded strings, plus
|
|
invalid-offset failures whose generic error did not meet the precise guidance
|
|
assertion. Both timestamp property names were exercised.
|
|
- `dotnet test .\src\tests\AutoForge.UnitTests\AutoForge.UnitTests.csproj --configuration Release --no-restore --filter FullyQualifiedName~VehicleProfileDomainTests`
|
|
exited 1: 1 failed, 24 passed, 0 skipped, 25 total. The module-only evidence
|
|
vector with all optional identities null failed direct Core construction
|
|
despite matching vehicle/profile/revision/module context and known target
|
|
identities.
|
|
- `dotnet test .\src\tests\AutoForge.IntegrationTests\AutoForge.IntegrationTests.csproj --configuration Release --no-restore --filter "FullyQualifiedName~PartialModuleEvidence|FullyQualifiedName~InvalidTimestamp"`
|
|
exited 1: 2 failed, 0 passed, 0 skipped, 2 total. The real profile-page/service
|
|
path rejected partial evidence applicability and accepted a time-only timestamp
|
|
instead of displaying the expected property error.
|
|
|
|
These are actual pre-fix executions, not inferred results. The integration
|
|
mutation helper was corrected to update profile applicability revisions when it
|
|
creates a new test revision; it also asserts the changed timestamp/identity paths
|
|
so the intended failure vectors cannot silently be missed.
|
|
|
|
## Regression coverage and after-fix results
|
|
|
|
Unit regressions now cover both `publishedAt` and `retrievedAt` for explicit
|
|
null, UTC Z, positive/negative numeric offsets, non-fractional input, one-digit
|
|
fractions, seven-digit exporter-style fractional input, and invalid time-only,
|
|
date-only, missing-offset, missing-year, culture/slash, padded, malformed-date
|
|
and invalid-offset values. Rejections assert the exact property path and
|
|
actionable format guidance. Exact `DateTimeOffset.EqualsExact` assertions verify
|
|
wall time, fractional ticks and offset. Export/reimport separately verifies the
|
|
existing seven-digit format.
|
|
|
|
Core regressions exercise module-only matching evidence with all four optional
|
|
identities null, each field omitted independently, mixed absent/supplied matching
|
|
constraints, preservation of known module values and classification, and both
|
|
module-level and capability-level evidence references. Negative cases cover
|
|
each identity mismatch against a known target and each supplied constraint
|
|
against an unknown target. Additional negative cases cover wrong vehicle,
|
|
profile, revision and module contexts; existing dangling-reference, conflicting
|
|
model-year, duplicate identity and evidence-resolution tests remain.
|
|
|
|
Real Application DI and actual routed UI integration tests:
|
|
|
|
- Import, explicitly select, export and reimport module-only evidence with all
|
|
four optional applicability identities null while module identities remain
|
|
known and unchanged.
|
|
- Reject an invalid timestamp on a distinct revision before registration and
|
|
show the exact JSON path/guidance; catalog contents and current explicit
|
|
selection remain unchanged.
|
|
- Reject a supplied conflicting module identity through the same real feature
|
|
service, render the scope error and preserve catalog/selection.
|
|
- Render the corrected positive import/export route through the actual profile
|
|
page/view model and retain existing target-selection isolation assertions.
|
|
|
|
After the fixes:
|
|
|
|
- Focused unit command:
|
|
`dotnet test .\src\tests\AutoForge.UnitTests\AutoForge.UnitTests.csproj --configuration Release --no-restore --filter "FullyQualifiedName~VehicleProfileJsonCodecTests|FullyQualifiedName~VehicleProfileDomainTests"`
|
|
exited 0: 64 passed, 0 failed, 0 skipped.
|
|
- Focused integration command:
|
|
`dotnet test .\src\tests\AutoForge.IntegrationTests\AutoForge.IntegrationTests.csproj --configuration Release --no-restore --filter FullyQualifiedName~VehicleProfileCompositionTests`
|
|
exited 0: 11 passed, 0 failed, 0 skipped.
|
|
|
|
## Full build and suite results
|
|
|
|
Commands were run sequentially, not concurrently:
|
|
|
|
- `dotnet build .\src\AutoForge.slnx --configuration Release --no-restore`
|
|
exited 0. All seven solution projects built, including the native Client at
|
|
`net10.0-windows10.0.26100.0` / `win-x64`; 0 warnings and 0 errors.
|
|
- `dotnet test .\src\AutoForge.slnx --configuration Release --no-build`
|
|
exited 0. AutoForge.UnitTests: 103 discovered/executed, 103 passed, 0 failed,
|
|
0 skipped. AutoForge.IntegrationTests: 37 discovered/executed, 37 passed,
|
|
0 failed, 0 skipped. Total 140 passed, 0 failed, 0 skipped.
|
|
|
|
The expanded suites include all 93 Step-02 worker-reported cases (59 unit, 34
|
|
integration); the prior Step-02 report remains historical evidence and was not
|
|
rewritten as if it covered these corrections. The final solution build itself
|
|
also built the native Client, so no separate direct Client build was necessary
|
|
for launching that exact Release executable. No package restore was needed.
|
|
|
|
## Native Windows smoke evidence
|
|
|
|
The actual Release native executable
|
|
`src/AutoForge.Client/bin/Release/net10.0-windows10.0.26100.0/win-x64/AutoForge.Client.exe`
|
|
was launched twice in a visible MAUI window with isolated WebView2 profiles and
|
|
temporary DevTools ports. The WebView title was `AutoForge`; its URL was
|
|
`https://0.0.0.1/`. Interactions were issued to the actual WebView DOM and the
|
|
resulting page/export values were inspected.
|
|
|
|
First run, process ID 56960, DevTools port 9338:
|
|
|
|
- Imported a baseline-derived profile containing a fractional explicit
|
|
`+05:30` publication time, UTC retrieval time, and module-only evidence with
|
|
all four optional identity fields null. Import did not auto-select. Explicit
|
|
revision-1 selection displayed the module's known hardware identity and export
|
|
retained all four evidence nulls. The fractional timestamp exported as
|
|
`2025-02-03T04:05:06.1234567+05:30`; UTC exported as
|
|
`2025-02-03T04:05:06.0000000+00:00`, preserving UTC offset/time/precision
|
|
semantics in the existing round-trip format.
|
|
- Attempted a time-only timestamp on a new revision. The UI showed
|
|
`$.evidence[1].retrievedAt` and explicit-offset format guidance. The catalog
|
|
remained at one revision and selected revision 1 remained selected.
|
|
- Attempted a conflicting supplied hardware constraint on another revision.
|
|
The UI displayed the conflicting module applicability error; catalog count
|
|
and explicit selection remained unchanged.
|
|
- Imported and explicitly selected the original synthetic truck variant
|
|
(revision 2) and verified its distinct `calibration.synthetic.engine-variant`.
|
|
- Imported and selected the original alternate orchard fixture and verified
|
|
its custom module role and unknown model year.
|
|
- Navigated to `/execution-targets`; the existing empty-provider metadata state
|
|
rendered and stated that no connection is attempted.
|
|
|
|
Second run, process ID 51724, DevTools port 9339:
|
|
|
|
- Imported the untouched source-controlled synthetic truck baseline, selected
|
|
revision 1 and verified the three-module export and original
|
|
`calibration.synthetic.engine-base`.
|
|
- Navigated to `/execution-targets` and verified the empty-provider metadata
|
|
route remained functional without connecting.
|
|
|
|
Both exact Client process IDs were stopped. Their exact temporary profiles
|
|
`AutoForge-Step02A-WebView2-9338` and `AutoForge-Step02A-WebView2-9339` were
|
|
removed. No screenshot was retained; results are from the live native DOM and
|
|
export state. The original source fixtures were not modified.
|
|
|
|
## Documentation and lifecycle status
|
|
|
|
Updated:
|
|
|
|
- `README.md`: Step-02A status, timestamp/absence-constraint behavior, current
|
|
worker test/build/native evidence and pending manual acceptance.
|
|
- `docs/vehicle-profile-schema-v1.md`: exact timestamp grammar, null/offset
|
|
behavior, absence-versus-supplied identity constraints and validation rules.
|
|
- `docs/adr-0003-profile-interchange-v1.md`: corrected decision and consequences.
|
|
- `docs/build-and-test.md`: current suite counts, distinct historical Step-02
|
|
evidence, correction/native smoke steps and safety constraints.
|
|
- `docs/README.md`: current worker/acceptance lifecycle and report links.
|
|
- Created this required worker report.
|
|
|
|
The seven-project graph and one Client/two RCL architecture remain unchanged.
|
|
Profile data remains process-local metadata. Timestamp/evidence classification
|
|
does not verify real-world accuracy, infer unknown identities, establish
|
|
compatibility, connect to hardware or authorize any operation.
|
|
|
|
## Acceptance criteria
|
|
|
|
| Criterion | Status | Evidence |
|
|
|---|---|---|
|
|
| AC-01: complete explicit-offset timestamp grammar or null; no ambient defaults | PASSED | Exact regex/date parse and offset validation; both fields tested across valid and invalid vectors, exact path and offset/tick assertions; native invalid-time error. |
|
|
| AC-02: absent optional module constraints remain absent; supplied constraints stay strict | PASSED | Direct-constructor all-null/single-null/mixed matrix; matching, known mismatch and unknown-target cases; identities/classification preserved. |
|
|
| AC-03: Core, JSON/service and actual UI consistency with atomic failure/selection | PASSED | Real DI/UI positive partial round-trip, exact timestamp failure, conflicting scope failure, unchanged catalog and selection; native paths confirmed. |
|
|
| AC-04: original fixtures, metadata, revisions, target isolation, prior 93 cases and architecture | PASSED | Full suite 140/140 includes original suites; actual baseline/variant/alternate native import/select/export and target route; seven-project build unchanged. |
|
|
| AC-05: pre-fix reproductions, full build/test and native verification | PASSED | Actual failing runs documented above; focused corrected suites pass; sequential full build has 0 warnings/errors; 103+37 tests and native scenarios pass. |
|
|
| AC-06: docs accurately describe contract and lifecycle | PASSED | README, schema guide, ADR-0003, build/test guide and docs index updated; manual acceptance remains pending. |
|
|
| AC-07: no unrelated feature/package/workload/orchestration/handoff; report complete | PASSED | Only R-01/R-02 source/tests/docs and required report changed by this worker; no workload-changing command, stage, commit, push, assignment/state/roadmap edit, agent or Step-03. |
|
|
|
|
## Corrected harness issues and deviations
|
|
|
|
- The first new integration-test compile surfaced xUnit analyzer xUnit2031 guidance
|
|
to use `Assert.Single(collection, predicate)` instead of filtering before
|
|
`Assert.Single`; the assertions were corrected before the reproduction run.
|
|
- The first partial-evidence integration vector changed the profile revision but
|
|
not its exact evidence applicability revision. The helper now updates every
|
|
applicable evidence revision and asserts the intended null/conflicting JSON
|
|
mutations before invoking the service.
|
|
- The first successful native import probe dispatched `input`, but the page
|
|
binds its textarea on `change`. The probe was corrected to dispatch `change`;
|
|
the actual native import then succeeded.
|
|
- An initial native verification compared exported UTC `Z` text lexically. The
|
|
existing round-trip exporter writes UTC as `+00:00` with seven fractional
|
|
digits. Verification was corrected to check the exact UTC wall time, zero
|
|
offset, retained fractional precision, and full `+05:30` value. No code change
|
|
was needed; this is the documented schema-v1 export representation.
|
|
- The first native summary script evaluated `document` in Node rather than inside
|
|
the WebView DevTools context. It was corrected to evaluate through CDP; native
|
|
scenarios then completed successfully.
|
|
- No scope or architecture deviation. No direct Client-only build was run
|
|
because the required full solution build successfully produced the exact
|
|
Windows Client target used in native smoke.
|
|
|
|
## Environment and preservation review
|
|
|
|
- Windows x64; .NET SDK 10.0.402; runtime 10.0.13.
|
|
- Windows SDK target 10.0.26100.0; MAUI Windows manifest 10.0.110; installed
|
|
workload version 10.0.403; WebView2 Runtime 155.0.4283.62.
|
|
- No packages were added or manifests changed. No restore was required.
|
|
- `dotnet workload list` was read-only. No workload install, update, restore,
|
|
repair, rollback or uninstall command was invoked.
|
|
- The worktree was already dirty before this assignment with Step-02 changes and
|
|
orchestrator-owned changes to `prompts/ROADMAP.md`, `prompts/STATE.md` and the
|
|
new `prompts/Step-02A.md`. Those pre-existing changes were preserved. This
|
|
worker did not modify any assignment, roadmap, state, previous report or
|
|
protected instruction file.
|
|
- The only file created under `prompts` by this worker is this report. The
|
|
`.github/copilot-instructions.md` file remains absent. Top-level project
|
|
directories remain `docs`, `src` and `prompts`.
|
|
- Modified documentation is LF-only with no trailing whitespace. Git
|
|
`core.autocrlf=true` causes the expected warning for the tracked LF
|
|
`README.md`, `docs/README.md` and `docs/build-and-test.md` that they will be
|
|
replaced by CRLF on a future Git touch; no global setting was changed.
|
|
- No staging, commit, push, destructive cleanup, automated handoff or agent
|
|
invocation occurred.
|
|
|
|
## Outstanding items and handoff
|
|
|
|
No worker implementation or required verification remains. Manual orchestrator
|
|
review and acceptance of the corrected Step-02 work remain outstanding. Do not
|
|
begin Step-03 until that acceptance and any further manual direction.
|
|
|
|
STOP here.
|
|
```
|