140 lines
9.4 KiB
Markdown
140 lines
9.4 KiB
Markdown
```
|
|
# Step-07B worker report
|
|
|
|
## Status
|
|
|
|
COMPLETE — Step-07B implementation and verification are complete. Manual
|
|
orchestrator review remains pending. Step-07 and Step-07A remain NOT ACCEPTED;
|
|
Step-08 remains blocked and was not started.
|
|
|
|
## Implementation
|
|
|
|
`DiagnosticSession.DisposeAsync` now uses `_lifetimeGate` only to establish
|
|
close ownership, publish the closed state, snapshot/clear registered resources
|
|
and publish a single shared disposal task. After releasing the gate, one
|
|
caller starts cancellation and resource/control/transport cleanup. Concurrent
|
|
callers return the same task and observe its actual completion or failure.
|
|
Late resource registration remains rejected after close ownership begins.
|
|
Existing resource ordering and error aggregation are unchanged.
|
|
|
|
The test-only `BarrierObservationProtocolClient` forwards actual calls and
|
|
observations from `SyntheticDiagnosticProtocolClient` and places a controlled
|
|
barrier in the actual capture subscription's dispose path. It exposes no
|
|
production race selector and does not mock the session, capture or protocol.
|
|
The cleanup-error regression uses a task-owned `IAsyncDisposable` resource.
|
|
|
|
Changed files:
|
|
|
|
- [DiagnosticSessionService.cs](../src/AutoForge.Application/Features/Vehicles/Diagnostics/DiagnosticSessionService.cs)
|
|
- [TelemetryRecordingIntegrationTests.cs](../src/tests/AutoForge.IntegrationTests/TelemetryRecordingIntegrationTests.cs)
|
|
- [README.md](../README.md)
|
|
- [docs/README.md](../docs/README.md)
|
|
- [architecture.md](../docs/architecture.md)
|
|
- [build-and-test.md](../docs/build-and-test.md)
|
|
|
|
## Pre-fix reproduction
|
|
|
|
Command:
|
|
|
|
`dotnet test .\src\tests\AutoForge.IntegrationTests\AutoForge.IntegrationTests.csproj --configuration Release --filter "FullyQualifiedName~SessionCloseDuringCaptureDetach_DoesNotDeadlockOrLoseFailurePrefix"`
|
|
|
|
Exit 1: the two theory cases failed and zero passed. Each case used controlled
|
|
barriers to establish the exact order: an actual diagnostic operation reached
|
|
capture limit/error detach after releasing the capture lock; close/reset
|
|
entered the second subscription-dispose call while the callback still owned
|
|
observation dispatch; then the callback barrier was released. After the
|
|
five-second safety deadline the test reported, for both the close and reset
|
|
cases, `Operation completed=False; close/reset completed=False.` This is the
|
|
observed lock cycle, not an inferred timing race or a compile failure. The
|
|
bounded xUnit process exited normally with the failures; no process tree had
|
|
to be terminated and no intentionally blocked task remained in a normal
|
|
passing run.
|
|
|
|
## Frozen corrective matrix
|
|
|
|
| Requirement | Evidence and result |
|
|
|---|---|
|
|
| C-01 normal stop/close with or without active capture | Existing stop-drain, repeated-registration, source-close retention, stopped saveability and cross-scope tests remain in the focused suite. Native static/dynamics workflow was also repeated. PASSED. |
|
|
| C-02 limit-detach competing with source close | `SessionCloseDuringCaptureDetach_DoesNotDeadlockOrLoseFailurePrefix(reset: False)` forces the callback/close interleaving above. Post-fix both operation and close complete, the one-observation prefix remains `Incomplete / LimitExceeded`, and session registration is released. PASSED. |
|
|
| C-03 observation-error detach competing with reset | The same regression with `reset: True` forces error detach against `DiagnosticSessionService.ResetAsync`. Post-fix both operation and reset complete; the original one-observation prefix remains `Error / ObservationFailure`; the replacement has a new session identity and its real signal read does not mutate the old snapshot. PASSED. |
|
|
| C-04 concurrent disposal, late registration and cleanup failure | `ConcurrentSessionDispose_SharesCompletionAndReportsCleanupFailure` verifies concurrent callers receive the same `Task`, late registration throws `ObjectDisposedException`, the controlled resource is disposed once, and both callers receive the same explicit cleanup exception. Barrier release is in `finally`. PASSED. |
|
|
| C-05 existing archive/registration/storage/panel/source/model/unit/native paths | All 310 Step-07A cases remain in the 313-test full suite; the three new theory/test cases pass. Fixed archive and capture limits, source semantics and native record/save/readback are preserved. PASSED. |
|
|
| AC-01 C-01..C-03 safe close/reset | Actual pre-fix lock-cycle reproduction and controlled post-fix completion/prefix/reason/replacement assertions. PASSED. |
|
|
| AC-02 C-04 shared cleanup semantics | Concurrent disposal identity/count, rejection and shared cleanup error assertions plus source ordering review. PASSED. |
|
|
| AC-03 C-05 regressions/build/native | 179 unit + 134 integration tests, nine-project Release build and native static/dynamics smoke. PASSED. |
|
|
| AC-04 scope/history/docs/self-review/report | Related documentation updated; protected files/history preserved; this report saved and worker stops before Step-08. PASSED. |
|
|
|
|
## Post-fix commands and results
|
|
|
|
Focused, build and full-suite commands ran sequentially:
|
|
|
|
| Command | Exit | Result |
|
|
|---|---:|---|
|
|
| `dotnet test .\src\tests\AutoForge.IntegrationTests\AutoForge.IntegrationTests.csproj --configuration Release --filter "FullyQualifiedName~SessionCloseDuringCaptureDetach_DoesNotDeadlockOrLoseFailurePrefix|FullyQualifiedName~ConcurrentSessionDispose_SharesCompletionAndReportsCleanupFailure"` | 0 | Three cases passed, zero failed/skipped. |
|
|
| `dotnet test .\src\tests\AutoForge.IntegrationTests\AutoForge.IntegrationTests.csproj --configuration Release --filter "FullyQualifiedName~TelemetryRecordingIntegrationTests"` | 0 | 29 passed, zero failed/skipped. |
|
|
| `dotnet build .\src\AutoForge.slnx --configuration Release --no-restore` | 0 | All nine projects, including Windows Client; zero warnings and zero errors. The XAML source-generation notice was informational. |
|
|
| `dotnet test .\src\AutoForge.slnx --configuration Release --no-build` | 0 | 179 unit + 134 integration = 313 passed; zero failed/skipped. |
|
|
|
|
The full suite preserves the 310-case Step-07A baseline (179 unit and 131
|
|
integration) and adds the two barrier theory cases plus one concurrent-dispose
|
|
case. Existing fixed limits remain 4,096 observations, 16 MiB encoded
|
|
observations, 1 MiB header, 32 MiB archive and JSON depth 128.
|
|
|
|
## Native versus controlled evidence
|
|
|
|
The rebuilt Windows Client was operated through its local WebView2 DevTools
|
|
endpoint:
|
|
|
|
- Static v1 recorded two actual operations (`read.dtcs` and `read.signals`),
|
|
stopped, then closed its source while the unsaved capture remained
|
|
inspectable. It was explicitly saved afterward. After app restart, the
|
|
archive loaded with its original raw bytes and two decoded signals.
|
|
- Dynamics v2 was explicitly stepped to model step 7 / 0.7 seconds. With
|
|
gauges hidden, two actual telemetry reads captured four actual
|
|
`read.signals` observations at the same model context. The capture was
|
|
stopped and the source closed before save; the stopped unsaved data remained
|
|
inspectable. After app restart, the archive loaded with raw data and decoded
|
|
source/model/configuration/run context.
|
|
- Both archives were loaded after restart. Metric/Road preferences remained
|
|
unchanged. Exact task-owned IDs were `3b6bbb098a094ac2ba10c042dcd4fbf0`
|
|
(static v1, two observations) and `ac5b4d4e814d4905a0d454292b4dde87`
|
|
(dynamics v2, four observations). After closing the Client and DevTools
|
|
listener, only those exact verified archive files were removed. The app's
|
|
existing/default WebView profile and unrelated application data were not
|
|
removed or reset.
|
|
|
|
Native evidence verifies normal static/dynamic record, stop, source close,
|
|
retained capture, explicit save, restart and readback. The exact race is
|
|
proved by controlled integration barriers, not by a human-timed native claim.
|
|
|
|
## Documentation, self-review and preservation
|
|
|
|
Updated the architecture contract to state that close ownership, closed-state
|
|
publication, resource snapshot and shared task publication occur under the
|
|
lifetime gate, while cancellation and resource/control/transport disposal run
|
|
after the gate is released. The root and docs READMEs now describe the
|
|
Step-07B correction and link this report. The build guide records the actual
|
|
pre-fix reproduction, final commands/counts and native/control distinction.
|
|
Step-07 and Step-07A reports and their positive archive/native evidence remain
|
|
unchanged.
|
|
|
|
Post-green self-review traced `DiagnosticSession.DisposeAsync` through close,
|
|
reset, cancellation, capture `StopForSourceClose`, limit/error detach,
|
|
unregistration, control and transport disposal. The gate is no longer held
|
|
while callbacks or observer drain run. `_disposeTask` is published before
|
|
another caller can start cleanup; registration checks the closed state under
|
|
the same gate; unregistration remains available after the close snapshot.
|
|
Disposal error aggregation and completion ordering are preserved. The
|
|
barrier tests assert operation and close/reset completion together, the exact
|
|
failure prefix/reason, registration release and replacement isolation. The
|
|
concurrent cleanup test releases its barrier in `finally`. No additional
|
|
issue was found in the review.
|
|
|
|
`git diff --check` passed. Only the six listed implementation/test/documentation
|
|
files and this requested report were changed. Step-07/07A assignment files,
|
|
historical reports, Step-07B assignment, state, roadmap and quality gate remain
|
|
unchanged. No package/project/system/workload changes, staging, commit, push,
|
|
or Step-08 work occurred. Step-07/07A acceptance remains for manual review.
|
|
Stop here.
|
|
```
|