AutoForge/prompts/STATE.md

1253 lines
99 KiB
Markdown

# AutoForge orchestration state
## Current handoff
| Field | Value |
|---|---|
| Updated | 2026-10-30 |
| Phase | Synthetic authoring accepted; isolated simulated programming rehearsal next |
| Active step | Step-10 - Verified simulated programming and recovery |
| Assignment | [Step-10.md](Step-10.md) |
| Assignment status | READY FOR WORKER / AWAITING MANUAL HANDOFF |
| Expected worker report | `prompts/Step-10-Report.md` - not yet created |
| Last accepted correction | Step-07B - accepted 2026-10-30 |
| Last accepted major milestone | Step-09 - accepted 2026-10-30 |
| Outstanding corrections | None |
| Step-02 status | ACCEPTED after Step-02A |
| Step-03 status | ACCEPTED after Step-03A/Step-03B |
| Step-04 status | ACCEPTED after Step-04A/Step-04B |
| Step-04A review | All original corrective criteria closed with Step-04B |
| Step-05 status | ACCEPTED after Step-05A/Step-05B |
| Step-05A review | All original corrective criteria closed with Step-05B |
| Step-06 status | ACCEPTED after Step-06A |
| Step-07 status | ACCEPTED after Step-07A/Step-07B |
| Step-07A review | All original corrective criteria closed with Step-07B |
| Step-08 status | ACCEPTED 2026-10-30; no correction required |
| Step-09 status | ACCEPTED 2026-10-30; no correction required |
| Step-10 status | READY FOR WORKER; isolated simulation image and volatile verified-backup/approval/write/readback/restore |
| Step-11 status | Local AI/runbooks; BLOCKED until Step-10 acceptance |
| Worker execution | Step-09 returned and accepted; Step-10 not invoked |
| Immediate next action | User manually directs the worker to execute Step-10 and shared quality gate only |
| Next orchestrator action | After manual return, inspect the assignment, report, implementation, tests, Git changes, documentation and recorded command evidence |
## Repository baseline at initialization
- Repository: `D:\_Repos\Code\GAJ3T\AutoForge`.
- Branch observed: `main`, tracking `origin/main`.
- Initial worktree: clean.
- Initial tracked files: root `README.md` and `.gitignore`.
- No existing solution, projects, tests, `docs`, `src`, or `prompts` were present.
- No applicable `AGENTS.md` was found in the repository or its ancestor locations.
- No `.github` instruction files were found. In particular,
`.github/copilot-instructions.md` was absent and must remain absent.
- Existing README describes the product vision, not verified implemented features;
Step-01 requires preserving it while making implementation status explicit.
- Existing `.gitignore` already includes common Visual Studio/.NET build patterns.
Worker must extend only where necessary and preserve existing entries.
- Initial orchestrator changes were limited to `prompts/ROADMAP.md`, this file,
and `prompts/Step-01.md`. Step-01 subsequently added the implementation below.
## Architecture decisions in force
See [ROADMAP.md](ROADMAP.md) for the full planned architecture and milestones.
1. The repository has only three top-level project directories: `docs`, `src`,
`prompts`; existing protected infrastructure is preserved. Tests are under
`src/tests`. No root `tests`, root `artifacts`, or nested `AutoForge` directory.
2. Keep the existing single `src/AutoForge.slnx`, Core, Application, UnitTests and
IntegrationTests. Accepted target-selection code/tests remain useful.
3. Sole initial application executable: AutoForge.Client, .NET 10 MAUI Blazor
Hybrid, initially Windows. No required standalone WebAssembly/web shell or
separate backend. Ordinary desktop capabilities run in-process as a modular
monolith; additional hosts/processes need a concrete approved requirement.
4. Accepted Step-01A established Client -> UI -> Components. Client is thin native startup,
BlazorWebView and DI/lifecycle/platform composition. UI owns complete routes,
pages, navigation/layouts and feature presentation. Components owns generic
reusable controls. UI cannot reference Client; Components cannot reference UI.
5. Application is needed now and retained. Organize use cases into cohesive feature
slices, beginning with existing execution-target selection. No mediator,
generic repository/manager layer, prescribed boilerplate or empty future slices.
UI invokes application contracts; business logic stays outside Razor components.
6. Reusable domain, simulation, diagnostic, calibration, telemetry and AI capability
libraries remain independently testable and are added only when justified.
They do not depend on Client/UI or their coordinating application slices.
Hardware, inference, storage and UI implementations never own domain truth.
7. Simulation, replay, and physical hardware targets are explicit and cannot
silently substitute for one another. Selection is not connection or execution.
8. Synthetic data is labeled; simulation is deterministic and independent of AI,
and verification uses an isolated oracle unavailable to ordinary UI/AI paths.
9. AI plans are validated runbooks; no arbitrary hardware commands or offsets.
Local inference is replaceable; core operation does not require AI/cloud.
10. Initial hardware integration is read-only. Simulated approval, physical
capability discovery, and driver availability cannot authorize physical writes.
Bench and vehicle programming require separate future authorization/evidence.
11. All handoffs are manual. Orchestrator never invokes the worker, implements
application changes, or executes application builds/tests.
12. The worker does not change the roadmap, state, or assignment; it may write only
the current assignment's report under `prompts`. No automatic commits/pushes.
## Historical Step-01 acceptance review
Decision at that review: **ACCEPTED**, 2026-10-28, with no identified blocking
defect under the then-current architecture. This acceptance and its evidence
remain historical facts. The later owner decision now requires Step-01A before
progression; it does not erase the accepted implementation or its reports.
Reviewed [Step-01](Step-01.md), the [worker report](Step-01-Report.md), all seven
production source files, all three test source files, four project files, solution,
five root configuration files, README/ignore diffs and all four technical documents.
The source enforces explicit identity/kind selection, case-insensitive uniqueness,
no cross-target fallback, immutable descriptors and registration snapshots.
Integration tests exercise the real DI/Core/Application path rather than mocks.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Expected README/ignore changes only among pre-existing implementation files; empty index; original assignment/roadmap/state hashes matched the report before orchestration updates; protected instructions absent |
| AC-02 | ACCEPTED | Actual root project directories are docs/src/prompts; tests under src/tests; no root tests/artifacts or nested repository |
| AC-03 | ACCEPTED | Inspected solution and all project references: Core has none; Application -> Core; both test projects -> Core/Application; all net10.0 |
| AC-04 | ACCEPTED | Inspected SDK policy, nullable/build/editor settings, central package pins and assets; worker records installed SDK 10.0.402 and actual VSTest execution |
| AC-05 | ACCEPTED | Descriptor/resolver/DI source satisfies explicit validation, uniqueness, snapshot and no-fallback requirements; no production provider is fabricated |
| AC-06 | ACCEPTED | All composition tests inspected; real container/service path covers positive selection and empty/invalid/mismatched/duplicate cases |
| AC-07 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported final Release build: zero warnings/errors; unit 35/35, integration 19/19, zero failures/skips; source case counts and existing restore/Release outputs corroborate the report |
| AC-08 | ACCEPTED | Documentation index, architecture/error contract/Mermaid, ADR, build/test guide and README describe actual scope and planned features accurately |
| AC-09 | ACCEPTED | No operational hardware/AI/UI dependency or extra placeholder project; no automatic handoff introduced |
| AC-10 | ACCEPTED | Complete report contains exact command outcomes, corrected failures, acceptance mapping and required sections in one plain copy window; no later implementation present |
Worker-reported execution: Windows x64, SDK 10.0.402, runtime 10.0.13;
restore, Release build and both suites succeeded after the documented
repository-local NuGet feed correction. Reported total: 54 passed, zero failed,
zero skipped. Existing assets confirm the framework/dependency graph; Release
binaries exist for all four projects. Their presence is corroboration, not an
independent test execution.
The orchestrator executed only read-only inspection and document/Git checks,
including static test-case counting and ignore-policy checks. It did **not**
execute dotnet, application builds, tests, formatting or hardware operations.
Runtime results are explicitly worker evidence. The worker's original report and
assignment remain unchanged; implementation is not committed by this review.
## Owner architectural realignment and current inspection
On 2026-10-28 the owner canceled the two-shell plan, required Client/UI/Components
and application Vertical Slice Architecture, and directed correction before
Step-02. [Step-01A](Step-01A.md) was the corrective assignment and is now accepted.
At correction planning, inspection found the original four-project solution unchanged:
Core has no dependencies, Application references Core and DI abstractions, and
both tests reference Core/Application. The existing target resolver and eager
registration are suitable for a feature slice and must be preserved.
There was no host/component implementation to delete or migrate. Correction was
additive UI composition plus feature organization, not a repository restart.
The old Step-02 was held, not executed.
After acceptance, [Step-02](Step-02.md) was regenerated from the seven-project
implementation and explicitly supersedes the prior unexecuted assignment. It now
uses application feature slices, reusable Core models and a thin profile metadata
consumer in the existing UI. Step-02 implementation/report now exist; acceptance
was initially withheld for the findings below and is now granted after Step-02A.
## Step-01A acceptance review
Decision: **ACCEPTED**, 2026-10-28. No Step-01B assignment is required.
Reviewed the [assignment](Step-01A.md), [worker report](Step-01A-Report.md),
solution and all project references, Client native/bootstrap/host code, RCL routes,
feature pages/view model/component/styles, moved Application feature, new rendered/
graph tests, package/build configuration, README and all affected technical docs.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Existing descriptor/resolver semantics and 54 prior cases retained; expanded suites contain 39 unit/26 integration cases; root layout/history/manual workflow preserved |
| AC-02 | ACCEPTED | Actual seven-project solution, one production executable, MAUI/Windows Client configuration and native Release output |
| AC-03 | ACCEPTED | MainPage hosts UI Routes through BlazorWebView; UI owns routes/layout/pages, Components owns StatusNotice; native route/assets observations reported |
| AC-04 | ACCEPTED | Project files, graph test and independent static traversal confirm Client -> UI -> Components, allowed Application references and no cycles |
| AC-05 | ACCEPTED | Feature folder contains real resolver/DI/errors with stable public namespace and unchanged explicit selection/snapshot/no-fallback behavior |
| AC-06 | ACCEPTED | Actual HtmlRenderer component/route tests use real Core/Application DI, cover errors/unknown routes and safe text rendering, without Client references |
| AC-07 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete Release solution and direct Windows Client builds: zero warnings/errors; 39 unit plus 26 integration passed, zero failed/skipped; matching source counts and Release outputs inspected |
| AC-08 | ACCEPTED ON WORKER NATIVE EVIDENCE | Detailed reported native home/selection/unregistered-physical/not-found checks, hidden error banner and both RCL CSS assets loading; native executable exists, not rerun by orchestrator |
| AC-09 | ACCEPTED | README/index/architecture/build guide and ADR-0001/0002 reflect one shell, two RCLs, VSA/modular monolith and metadata-only limitations |
| AC-10 | ACCEPTED | Evidence-bearing report, corrected failures and environment deviation disclosed; historical reports/assignments preserved and Step-02 unexecuted |
Worker-reported verified platform: SDK 10.0.402, runtime 10.0.13, Windows
10.0.26100.0/win-x64, MAUI Windows manifest 10.0.110 and WebView2 155.0.4283.62.
The source counts, framework/assets, seven-project graph and native/portable
Release artifacts corroborate the report. They do not prove an independent
runtime run. No application builds/tests/native launch were performed here.
Acceptance covers the application correction, not approval of the unintended
workload action or a claim that the broader tool environment is unchanged.
The deviations below are non-blocking for this verified Windows foundation and
must remain visible. No environment rollback or source fix was attempted.
## Historical Step-02 review and corrective decision
Initial decision: **REQUIRES CORRECTION**, 2026-10-28. The findings and criterion
table below describe the pre-correction implementation. They are preserved as
history and closed by the Step-02A acceptance review that follows.
Inspected the [assignment](Step-02.md), [worker report](Step-02-Report.md),
complete new Core/profile codec/catalog/DI/UI code, all new unit/integration
tests, synthetic fixtures, existing composition/reference changes, README and
affected technical/schema/ADR documentation.
| Criterion | Review result | Evidence / remaining work |
|---|---|---|
| AC-01 | Preserved on inspected evidence | Same seven-project graph, existing target/UI regressions and manual/protected workflow; no new dependency or shell |
| AC-02 | Present; validation correction required | Immutable profile/revision/module model works for supplied fixtures, but valid partial module-evidence context is rejected |
| AC-03 | Present on inspected evidence | Five capability states, custom operations and explicit undeclared Unknown retained; no operational authority |
| AC-04 | NOT SATISFIED | R-02 treats absent optional evidence identity constraints as exact null matches, rejecting compatible module-scoped evidence |
| AC-05 | NOT SATISFIED | R-01 permits incomplete timestamp strings that infer ambient date or offset, violating explicit schema data |
| AC-06 | Existing path inspected; correction regressions required | Real DI catalog/UI and atomic failed imports exist; both findings need direct/service/UI regression coverage |
| AC-07 | Present on inspected evidence | Three synthetic fixture documents cover baseline, variant, alternate/custom module and all five states |
| AC-08 | Existing suite passed per worker; insufficient coverage | Reported 59 unit + 34 integration passed, zero failed/skipped; solution/native build and native smoke passed; findings are absent from this coverage |
| AC-09 | Corrective alignment required | Documentation exists, but timestamp/optional applicability behavior must match the stated contract and correction status |
| AC-10 | Report/preservation inspected | Required report and scope evidence present; original assignment/report remain unchanged; no Step-03 |
### R-01 - Ambient-dependent timestamp import
[VehicleProfileJsonCodec.cs](../src/AutoForge.Application/Features/Vehicles/Profiles/VehicleProfileJsonCodec.cs),
line 478, delegates to DateTimeOffset.TryParse with RoundtripKind. Official .NET
documentation states that a missing date defaults to the current day, a missing
offset defaults to the local time zone, and RoundtripKind has no effect for this
type. Time-only, date-only and offset-free date/time strings therefore are not
reliably rejected by this supposedly explicit/clock-independent import contract.
Both publishedAt and retrievedAt use this path.
### R-02 - Absent evidence constraints rejected
[VehicleProfile.cs](../src/AutoForge.Core/Vehicles/VehicleProfile.cs), lines 367
and 408, validates each optional module identity using a helper that requires both
values to be null when the evidence field is null. A module with known hardware
cannot accept module-scoped evidence that leaves hardware applicability
unspecified, even when vehicle/profile/module and all supplied constraints match.
This contradicts the documented optional identity context. Fix absence handling
without weakening supplied-constraint or unknown-target checks.
These are source/contract findings, not claims of independently executed failures.
Official API documentation corroborates R-01; Step-02A requires worker
reproduction, corrected regressions and native/UI evidence, now supplied and
reviewed below.
Worker-reported Step-02 execution remains historical: complete seven-project and
direct native Release builds with zero warnings/errors; 59 unit and 34 integration
cases passed, zero failed/skipped; native profile import/select/variant/error/export
and old route/asset checks reported. Static test counts, fixture shape, restore
assets and Release/native artifacts corroborate it. No build/test/native/workload
command was executed by the orchestrator.
## Step-02A acceptance and corrected Step-02
Decision: **ACCEPTED**, 2026-10-28. Step-02A closes R-01/R-02; the corrected
Step-02 milestone is accepted. No Step-02B is required.
Reviewed [Step-02A](Step-02A.md), its [report](Step-02A-Report.md), the complete
new timestamp parser/shared evidence helper, correction unit/real DI/rendered UI
tests, data mutation helpers, schema/ADR/README/testing updates and project scope.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Anchored ASCII full-date/time/offset grammar, exact invariant calendar parse, bounded minute offset and typed property failures; both timestamp fields have positive/negative vectors and exact offset/tick assertions |
| AC-02 | ACCEPTED | Null constraint is absence; non-null requires known matching target; each-field omission/matching/mismatch/unknown-target constructor tests and all-null real DI round-trip inspected |
| AC-03 | ACCEPTED | Actual service/page path accepts module-only evidence, rejects timestamp/supplied mismatch, preserves catalog/current selection and renders explicit errors |
| AC-04 | ACCEPTED | Previous 93 cases remain in the expanded 140-case suite; fixtures, seven-project graph, metadata/target isolation and public contracts retained |
| AC-05 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported actual pre-fix failures; focused corrected runs; complete sequential Release build 0 warnings/errors; 103 unit + 37 integration passes, zero failed/skipped; native scenarios and original fixtures observed |
| AC-06 | ACCEPTED | Schema/ADR specify precise grammar/null/offset limits and absent-versus-supplied identity constraints; README/index/test guide preserve historical versus corrective results |
| AC-07 | ACCEPTED | Scope remains two fixes/tests/docs/report; no new package/project/workload action or later-step implementation; historical assignments/reports preserved |
Coverage precision: the direct unit helper's null label retains all known
constraints, while its four named cases omit each constraint individually.
The separate real DI/UI integration test supplies all four nulls and constructs/
round-trips the actual Core model. Acceptance uses that combined inspected
coverage, not an assumption that the unit loop's null label means all-null.
Worker-reported execution: SDK 10.0.402/runtime 10.0.13; Windows target
10.0.26100.0/win-x64; MAUI Windows manifest 10.0.110; WebView2 155.0.4283.62.
Before-fix command outcomes and focused runs are recorded in the unchanged report.
Final build: complete seven-project Release solution, zero warnings/errors.
Final suites: 103 unit and 37 integration passed, zero failed/skipped.
Native observations include full explicit-offset timestamps/partial evidence,
exact invalid-time path, conflicting supplied constraint with unchanged catalog/
selection, original baseline/variant/alternate imports and target metadata route.
Static source case counts, seven-project acyclic references, restored assets,
Release assemblies and native executable corroborate the report. The orchestrator
did not execute application builds/tests/native launch or workload commands.
The original Step-02 and Step-02A assignments/reports remain historical evidence.
Step-03 is prepared against the actual accepted profile/Application/UI baseline.
It assigns Diagnostics and Simulation as two real new library boundaries, with
provider-neutral Application features and Client composition. They now exist
and the corrected Step-03 milestone is accepted; dynamics/physical adapters remain
unimplemented until their separate assignments.
## Historical Step-03 review and corrective decision
Initial decision: **REQUIRES CORRECTION**, 2026-10-28. R-01/R-02/R-03 below
describe the pre-Step-03A code and are now closed. Step-03 still requires the
additional R-04 correction recorded after the Step-03A review below.
Inspected the [assignment](Step-03.md), [worker report](Step-03-Report.md),
Diagnostics contracts/codec/client, Simulation definitions/provider/state and
internal oracle, application session service, UI view model/page, new protocol/
session/rendered tests, project references, README and protocol/simulation/ADR/
build documentation.
| Criterion | Review result | Evidence / remaining work |
|---|---|---|
| AC-01 | Preserved on inspected evidence | Nine-project graph, sole Client, no reverse references/cycles and IntegrationTests-only internal oracle |
| AC-02 | Present on inspected evidence | Explicit exact profile/provider/kind/session selection and reset/close with no fallback |
| AC-03 | Present; validation correction required | Real frames traverse transport, but omitted/duplicate request fields and semantically invalid positive replies are not adequately rejected |
| AC-04 | Normal flow works per inspected/reported evidence | State isolation, read/clear/reset and static signals present; R-03 must detect clear acknowledgement without empty readback |
| AC-05 | NOT SATISFIED | R-01/R-02 expose malformed/ambiguous frames and invalid typed data outside existing fault tests |
| AC-06 | NOT SATISFIED | Probe identity mismatch becomes a discovery ProtocolError after its exchange was already traced PositiveResponse |
| AC-07 | Corrective verification required | UI/session/provider composition is real, but nonempty successful readback is labeled cleared/verified |
| AC-08 | Existing suite passed per worker; insufficient coverage | 108 unit + 53 integration passed, zero failed/skipped; complete Release/native build and native smoke reported; new vectors not covered |
| AC-09 | Corrective alignment required | Documentation exists; wire presence/ambiguity, semantic validation and verified-clear contracts/lifecycle must be aligned |
| AC-10 | Report/preservation inspected | Required report and scoped changes present; original assignment/report preserved; no Step-04 |
### Step-03 R-01 - Required and unambiguous frames
[SyntheticProtocolV1.cs](../src/AutoForge.Diagnostics/SyntheticProtocolV1.cs),
lines 45 and 82, defaults Version to 1 and deserializes without requiring its
presence or rejecting duplicate JSON properties. Omitting version leaves a valid
v1 object; omitting logicalTimeTicks can leave zero. Repeated service/version/
correlation fields can be resolved by last-value deserialization rather than
rejected. With otherwise valid session binding, the transport can dispatch a
virtual clear from a malformed/ambiguous request.
### Step-03 R-02 - Service semantics and truthful trace
[SyntheticDiagnosticProtocolClient.cs](../src/AutoForge.Diagnostics/SyntheticDiagnosticProtocolClient.cs),
line 143, reads signal ticks and strings into unvalidated result records.
For example a negative logicalTimeTicks or blank signal ID/unit can still become
PositiveResponse. DTC strings likewise lack semantic validation.
The probe module-identity check at line 55 occurs outside the exchange decoder.
A mismatched probe is recorded positive at line 289 before discovery converts it
to ProtocolError. Returned outcome and raw exchange trace therefore disagree.
Validate the complete interpreted payload before positive result/trace commitment.
### Step-03 R-03 - Acknowledgement versus verified clear
[DiagnosticPageViewModel.cs](../src/AutoForge.UI/Features/Vehicles/Diagnostics/DiagnosticPageViewModel.cs),
line 261, tests only readback.IsSuccess and then says the state was cleared.
A successful response containing remaining DTCs still takes this success path.
The logical use case must fail verification when readback is nonempty or
failed/unknown/cancelled, while preserving the actual observed data and no
physical-operation claim.
These are static source/contract findings, not parent-executed reproductions.
The worker subsequently supplied actual reproductions and corrected evidence.
Reported Step-03 evidence remains historical: complete nine-project/native Release
build zero warnings/errors; 108 unit + 53 integration passed, zero failed/skipped;
native explicit open/probe/read/clear/reset/close/trace and old routes observed.
Static case counts, graph, restore assets and Release/native outputs corroborate
the report. No build/test/native/workload command was executed by the orchestrator.
## Historical Step-03A scoped acceptance and additional discovery finding
Decision: Step-03A's **R-01/R-02/R-03 corrections ACCEPTED**, 2026-10-28.
At that review the parent Step-03 milestone was **NOT ACCEPTED**: R-04 required
Step-03B. The three successful corrections remain closed; R-04 is now also
closed by the subsequent acceptance review below.
Reviewed [Step-03A](Step-03A.md), its [report](Step-03A-Report.md), strict wire
presence/uniqueness logic, complete reply/trace validation, Application verified
clear/result and UI adaptation, unit/state-oracle/real-DI/rendered fault tests,
test-only rewriting transport and directly related docs.
| Criterion | Scoped decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | All ten request fields required, explicit zero retained, duplicate/unknown fields rejected; malformed clear vectors leave independent state unchanged |
| AC-02 | ACCEPTED | Exact reply/service shapes, semantic identifiers/timing/uniqueness and positive/error/data consistency validated before positive result; malformed vectors return no value |
| AC-03 | ACCEPTED | Wrong probe module is now checked within the exchange decoder; one matching ProtocolError trace retains actual request/reply rather than false positive |
| AC-04 | ACCEPTED | Application clear-and-verify separates acknowledgement/readback, rejects nonempty/failed/unknown readback, preserves remaining codes and renders failure |
| AC-05 | ACCEPTED WITHIN CORRECTIVE SCOPE | Original 161-case baseline retained, nine-project graph/state/target/profile/clock boundaries unchanged; R-04 is an additional pre-existing discovery case |
| AC-06 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported actual 2-unit/5-integration pre-fix failures; corrected focused runs; full Release build 0 warnings/errors; 111 unit + 64 integration passes, zero failed/skipped; native baseline observed |
| AC-07 | ACCEPTED | README/protocol/simulation/ADR/test docs reflect corrected wire/verification and historical versus corrective results |
| AC-08 | ACCEPTED | No new project/package/workload action or future step; original assignments/reports and orchestration files preserved by worker |
Worker-reported final coverage: 175 passed (111 unit, 64 integration), zero
failed/skipped. Native evidence covers genuine verified clear/empty readback,
probe/read/trace/reset/close and old routes. The false-ack/nonempty-readback fault
is explicitly real DI/rendered integration evidence, not native coverage; the
production Client has no runtime fault control and none was added just for proof.
Static source case counts, nine-project acyclic graph and existing restore/
Release/native artifacts corroborate the report, not independent runtime
execution. The orchestrator did not run builds/tests or launch the app.
### R-04 - Successful probe evidence discarded when identity is unavailable
[SyntheticDiagnosticProtocolClient.cs](../src/AutoForge.Diagnostics/SyntheticDiagnosticProtocolClient.cs),
line 72, always follows a valid probe with an identity read, then constructs the
entry solely from identity outcome and drops the validated service list when
identity fails. [ProviderContracts.cs](../src/AutoForge.Diagnostics/ProviderContracts.cs),
line 257, defines Responders as non-null identities.
[DiagnosticPageViewModel.cs](../src/AutoForge.UI/Features/Vehicles/Diagnostics/DiagnosticPageViewModel.cs),
line 132, labels this identity count as actual endpoints that responded.
A valid module definition implementing `probe` but not `read.identity` is allowed.
It returns a positive validated probe and an unsupported identity reply, yet it
is omitted from the responder count. Likewise, a successful probe is lost if
the subsequent identity reply is malformed, timed out or cancelled. Reachability,
advertised services and identity verification are different facts.
Step-03B was required to preserve both phase outcomes, keep valid probe/service evidence,
label probe responders versus identified modules honestly, and keep unavailable
identity explicit without fabricating profile-derived identity or relaxing
existing identity-dependent action guards. The source finding was not executed
by the orchestrator; the worker subsequently supplied the pre-fix reproduction
reviewed below.
## Step-03B acceptance and corrected Step-03
Decision: **ACCEPTED**, 2026-10-28. Step-03B closes R-04; corrected Step-03 is
accepted with Step-03A/Step-03B. No Step-03C is required.
Reviewed [Step-03B](Step-03B.md), its [report](Step-03B-Report.md),
phase-specific discovery/probe/identity models and aggregation, UI summary/rows/
guards, actual Simulation/DI/rendered regression tests, trace assertions and
directly related protocol/simulation/ADR/README/testing documentation.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Valid positive probe and immutable services retained independently of optional identity result; unsupported/unavailable identity stays null with explicit phase reason |
| AC-02 | ACCEPTED | Expected/probed/identified counts distinct; partial UI preserves services and unknown identity; controls disabled and direct view-model guards emit no operation |
| AC-03 | ACCEPTED | Negative/malformed/mismatched/timed-out/cancelled identity preserves positive probe and its own trace; failed probe does not invent identity/services; close clears active presentation |
| AC-04 | ACCEPTED | Normal synthetic workflow, R-01/R-02/R-03, profile/target/state/oracle boundaries and nine-project graph retained; 175 prior cases included in 183 |
| AC-05 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported actual pre-fix phase-conflation failure; focused 35 passes; complete Release build zero warnings/errors; 111 unit + 72 integration passes, zero failed/skipped; native baseline observed |
| AC-06 | ACCEPTED | README/protocol/simulation/architecture/ADR/testing docs describe phase/count/action policy and native versus rendered evidence |
| AC-07 | ACCEPTED | Only scoped source/tests/docs/report work; previous assignments/reports and orchestration files preserved; no new project/package/workload action or future step |
Chosen policy: a validated probe without advertised read.identity does not issue
an unsupported identity request. Its probe/services remain available as claims;
identity is explicitly not attempted and never populated from profile metadata.
Identity-dependent actions stay fail-closed.
Worker-reported coverage: 183 passed (111 unit, 72 integration), zero failed/skipped.
Native baseline covers explicit load/open, 3 expected/2 successful probes/2
identified modules, no-response, read/static signals/raw trace, verified clear,
reset/close and old routes. Partial-identity faults/action guards/cancellation are
real-DI/rendered test coverage, not claimed native fault coverage.
Static source counts, nine-project acyclic references and existing restore/
Release/native artifacts corroborate the report. No application build/test/
native/workload command was executed by the orchestrator.
Step-04 is prepared against the actual accepted interfaces. It assigns a separate
explicit dynamics provider/configuration, fixed-step clock/model/scenario controls,
configuration-preserving reset and versioned dynamic telemetry through diagnostics.
The dynamics implementation now exists under review, still without any extra
executable/project, physical integration or calibration programming.
## Historical Step-04 review and corrective decision
Initial decision: **REQUIRES CORRECTION**, 2026-10-28. The original findings
below describe pre-Step-04A code. At the follow-up, most were fixed but an
overlap criterion still required Step-04B. The closing review below now accepts
the corrected milestone.
Inspected the [assignment](Step-04.md), [worker report](Step-04-Report.md),
configuration/initial/model validation and fingerprinting, complete physics/
scenario/control implementation, dynamic provider and v2 binding, Application
configuration/session paths, UI controls/status, all new unit/integration tests
and related model/protocol/build documentation.
| Criterion | Review result | Evidence / remaining work |
|---|---|---|
| AC-01 | Present; reference correction required | Immutable config/shape/fingerprint and profile binding exist; missing profile/module references can escape the import UI's handled exception contract |
| AC-02 | NOT SATISFIED | Progress resets at phase boundaries and async owner/active-pacer behavior lacks controlled proof; tests use wall delays/polling |
| AC-03 | Present on inspected evidence | Separate static/dynamics factories and exact original-config reset/session isolation implemented; no fallback or extra project |
| AC-04 | NOT SATISFIED | Initial and runtime locked-RPM/speed/gear consistency is not guaranteed across accepted inputs; independent force tests are absent |
| AC-05 | Baseline passed per worker | Default 650-rpm/45-MPH/full 300-s hold/stop/repeatability gates are meaningfully asserted; broader boundary inputs are not covered |
| AC-06 | Present; fault policy correction required | Actual strict v2 snapshots and static v1 compatibility exist; faulted/invalid model state must not become healthy success or an unhandled serialization failure |
| AC-07 | Corrective lifecycle/status required | Real controls/table/DI exist; faulted-run success notices, overwritten cancellation ownership and stale async publication require correction |
| AC-08 | Existing suite passed per worker; insufficient coverage | 115 unit + 75 integration passed, zero failed/skipped; complete Release/native and numerical baseline evidence supplied; review vectors not covered |
| AC-09 | Corrective alignment required | Equations/contracts/native guide present; operating envelope, fault/progress/clock ownership and corrected verification need documentation |
| AC-10 | Report/preservation inspected | Required report, nine-project scope and prior history preserved; no Step-05 |
### Step-04 R-01 - Unhandled configuration reference errors
[DynamicsConfigurationService.cs](../src/AutoForge.Application/Features/Vehicles/Simulation/DynamicsConfigurationService.cs),
line 68, selects the referenced profile inside Import but catches only JSON and
argument exceptions. Missing profile/revision throws VehicleProfileCatalogException.
[DynamicsConfiguration.cs](../src/AutoForge.Core/Simulation/DynamicsConfiguration.cs),
line 340, uses GetModule and can throw KeyNotFoundException for a missing module.
[SimulationPageViewModel.cs](../src/AutoForge.UI/Features/Vehicles/Simulation/SimulationPageViewModel.cs),
line 106, handles only DynamicsConfigurationException for import. Those valid
JSON/invalid-reference inputs can therefore escape the ordinary visible-error
path instead of leaving a usable page with actionable input feedback.
### Step-04 R-02 - Unsupported or contradictory drivetrain states
Configuration checks RPM range/gear count but not redundant initial kinematics.
For example a running first-gear state at 10 m/s and 650 rpm is accepted under
the default ratios even though reset publishes zero slip and the wheel equation
requires a different RPM. Reading before any step exposes the contradiction.
[DynamicsEngine.cs](../src/AutoForge.Simulation/DynamicsEngine.cs), line 385,
independently caps coupled RPM with Math.Min while leaving speed/gear and zero
slip unchanged. Allowed high-speed/shift configurations can violate the promised
locked equation. At line 368, a slipping condition caused by below-idle wheel RPM
can also produce zero reported slip when speed exceeds a low configured launch
threshold. Validation or truthful modeled limits/slip/failure must replace those
healthy contradictory states, without gaming the default cruise gate.
### Step-04 R-03 - Progress, terminal failures and async ownership
[DynamicsEngine.cs](../src/AutoForge.Simulation/DynamicsEngine.cs), line 486,
clears cumulative completed time immediately after adding the finished phase,
so scenario progress drops at phase transitions.
[SimulationPageViewModel.cs](../src/AutoForge.UI/Features/Vehicles/Simulation/SimulationPageViewModel.cs),
line 204, reports every returned scenario status via SetSuccess, including
Faulted; RefreshTelemetryAsync can overwrite the failure with another success.
The run method also replaces its pending cancellation slot before rejecting a
second runner, leaving the first runner no longer reachable through Cancel.
Post-await status/data publication lacks the earlier diagnostic UI's current-
session guard, so old work can update presentation during reset/close/reopen.
Finite/domain failures mutate engine fields before checking them. The producer
can then read that failed snapshot and serialize positive Good telemetry;
non-finite fields can instead escape as a serialization exception. A clear
failed-run/last-valid-snapshot or typed negative policy is required.
The active pacer uses direct Task.Delay; the lifecycle test uses fixed wall delays
and polling, and repeatability tests bypass the pacer. Add a controlled scheduler/
time seam and actual active-run pause/resume/stop/reset/restart/close and pacing
tests, plus independent force/kinematic boundary evidence.
All findings are source/contract review, not orchestrator-executed failures.
Worker baseline evidence remains historical: complete nine-project/native Release
build zero warnings/errors; 115 unit + 75 integration passed; 3,361 equal samples,
10 s warm idle, 10.3 s acceleration, 3,000/3,000 cruise samples in band/coupled,
5.8 s braking and 10 s return idle, plus actual native workflow. These useful
default results do not prove the missing boundary/failure/lifecycle cases.
Source case counts, graph and existing artifacts corroborate the report.
## Historical Step-04A review and focused follow-up
Decision at that review: most scope was satisfied, but existing R-03/AC-04
required Step-04B. The follow-up below has now closed that condition.
Reviewed [Step-04A](Step-04A.md), its [report](Step-04A-Report.md), typed
reference handling, initial/runtime coupling/limit guards and rollback, phase/
overall progress, terminal v2 failures, UI generations/cancellation ownership,
actual controller/pacer code, independent numerical and controlled tests and docs.
| Criterion | Review result | Evidence / remaining work |
|---|---|---|
| AC-01 | Satisfied on inspected/reported evidence | Missing profile/revision/module/calibration inputs are typed and atomic; rendered/native recoverable input errors reported |
| AC-02 | Satisfied on inspected/reported evidence | Initial coupled relation, redline validation/runtime guard, actual RPM-discrepancy slip and rollback; independent force/RPM boundary tests |
| AC-03 | Satisfied on inspected/reported evidence | Cumulative/phase progress corrected, fault snapshots rollback, negative DYNAMICS_RUN_FAULTED, persistent error and no healthy poisoned telemetry |
| AC-04 | NOT YET SATISFIED | Sequential controlled lifecycle and UI owner tests improved, but Start/Resume can mutate before rejecting an undrained advancement task |
| AC-05 | Existing regressions/numerical gates retained | Reported unchanged 3,361-sample baseline and all 190 cases within 202 passes; static/profile/wire/clear/discovery/source graph preserved |
| AC-06 | Reported execution inspected | Before-fix reference/coupling/progress failures, corrected focused runs, clean complete Release build, 122 unit + 80 integration passes and native smoke supplied |
| AC-07 | Satisfied on inspected evidence | Directly related model/config/lifecycle/v2/README/testing documentation updated |
| AC-08 | Preservation/scope inspected | Only scoped correction/source/tests/docs/report; no new project/package/workload action, orchestration/history edit or later step |
### Remaining existing criterion: reject before lifecycle mutation
[DynamicsEngine.cs](../src/AutoForge.Simulation/DynamicsEngine.cs),
StartOrResumeAsync around line 772 calls engine.Start/Resume before
StartRunnerLocked checks its still-active task. StopRunnerAsync changes state,
cancels the owner, releases the gate and then awaits its completion.
If Resume/Start arrives while that cleanup is pending, the engine can become
Running and only then throw "already active". The cancelled old owner exits and
the rejected command can leave Running without an owner. A rejected operation
must wait under a documented policy or leave state unchanged; it cannot mutate
first. Existing controlled tests await Pause/Stop/Reset before the next start/
resume, so the pending-transition overlap is absent.
This is a source/contract finding within the original Step-04A overlap/lifecycle
criterion, not a new requirement introduced by the owner's process-improvement
request. The orchestrator did not execute it; Step-04B requires a controlled
pre-fix reproduction and is limited to this issue.
Worker-reported Step-04A results remain historical: full nine-project/native
Release build zero warnings/errors; 122 unit + 80 integration passed (202 total,
zero failed/skipped); unchanged default numerical gates, independent force
equations, controlled pacing comparison and native input/fault/baseline smoke.
Source counts, graph and existing artifacts corroborate that evidence; the
orchestrator ran no application builds/tests/native/workload commands.
## Step-04B acceptance and corrected Step-04
Decision: **ACCEPTED**, 2026-10-28. C-01 through C-05 and the remaining
Step-04A criterion are satisfied; corrected Step-04/04A/04B are accepted.
No Step-04C is required.
Reviewed [Step-04B](Step-04B.md), its [report](Step-04B-Report.md), the shared
owner precondition before all start mutations, complete controlled status/
sample assertions for pending pause/stop/reset, cleanup/retry/invalid/disposed
cases, real SimulationPage service/UI rejection and documentation/self-review.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | All frozen cases covered; EnsureNoActiveAdvancementOwner precedes engine.Start/Resume/scenario state changes, with defensive check retained at owner installation |
| AC-02 | ACCEPTED | Old task drains without holding its cleanup gate; rejection preserves full status/sample count; one retry advances once; real UI error never reports resumed success |
| AC-03 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete Release build zero warnings/errors; 126 unit + 81 integration passes (207 total, zero failed/skipped), original numerical gates and native lifecycle/reset/telemetry smoke |
| AC-04 | ACCEPTED | C-01..C-05 matrix, actual pre-fix observations, source-path self-review and matching lifecycle/README/testing policy |
| AC-05 | ACCEPTED | Single-issue guard/tests/docs/report change, no new project/package/interface/physics/protocol; historical assignments/reports and orchestration files preserved |
Worker source-path self-review explicitly walks precondition order, producer/
consumer callers, failure cleanup and barrier-finally behavior. The exact race
is controlled unit/real-DI/UI evidence, not claimed human-timed native proof.
Static source case counts, nine-project acyclic references, restored assets,
Release assemblies and native output corroborate the report. The orchestrator
did not execute application builds/tests/native/workload commands.
Step-05 is prepared under the revised prospective policy: one user outcome,
one acquisition-owner contract, numeric/bar rendering and validated in-memory
configuration. No new persistence/wire format, clock/model, project or host.
The frozen matrix states missing/uncertain/stale/range and source-lifetime
outcomes before coding; future enhancements stay out of acceptance.
## Prospective orchestration/process improvement
The owner requested fewer corrective handoffs through better planning/prompts.
The [revised roadmap policy](ROADMAP.md) and
[WORKER-QUALITY-GATE.md](WORKER-QUALITY-GATE.md) now require:
- Smaller capability-complete assignments instead of several new subsystems/
state machines/formats in one handoff.
- A compact agreed input/outcome/transition matrix before implementation.
- Worker source-path self-review after the first green run, fixing issues inside
the active assignment before COMPLETE.
- Evidence mapped to exact cases/invariants, not test-count proxies.
- One consolidated review against frozen criteria; new preferences are planned,
not retroactively called defects.
The rules apply to new work beginning with Step-04B, not retroactively to
Step-04A. No automated agents/handoffs or weaker quality bar is introduced.
Step-01A was owner-driven architecture change, not an implementation-quality
failure. Earlier technical cycles exposed contract/coverage and overlarge-scope
gaps; orchestration shares responsibility for those gaps.
The Step-05 dashboard envelope remains limited to numeric/bar gauges,
validated bindings/ranges/units and missing/stale states with one acquisition
owner. Basic add/edit/remove controls are already assigned; advanced charts and
layout designers stay later. Future broad calibration/AI/
hardware envelopes must be split before assignment if needed; history is not
renumbered and corrective letters are not used for planned features.
## Historical Step-05 review and required completion
Decision at that review: **REQUIRES CORRECTION / NOT ACCEPTED**, 2026-10-29.
The [returned report](Step-05-Report.md) says PASSED with native smoke NOT EXECUTED.
That is not satisfaction of [Step-05](Step-05.md) or its shared exit gate.
Step-05A addresses only existing C-01..C-10/AC-01..AC-07; no new feature is assigned.
Reviewed all new dashboard models/acquisition/component code and tracked host/DI
changes, actual diagnostic session cancellation/disposal, existing route tests,
simulation host inventory, technical-document status, nine-project references
and existing Release outputs. Source review identifies:
| Finding | Evidence | Original contract |
|---|---|---|
| R-01 - incomplete/broken configured host workflow | DiagnosticPageViewModel validates generated definitions before its fresh feed has read bindings; with no prior reads it starts empty and has no editor. Only Numeric defaults exist; simulation host is unwired. Start disables on any snapshot, including Stopped, and background refresh changes fields without a page render notification. | C-01/C-04/C-10, required UI section, AC-01/AC-04 |
| R-02 - owner/source lifetime | Factory Create always returns a new independent feed. Its token is not session-linked. Close/reset stops but never clears/disposes the old feed/callback, so later startup reuses the old session; scope disposal is not implemented. Direct session close does not end the poll loop. | C-05/C-06/C-07, AC-02 |
| R-03 - false current data and failed cleanup | Error feed state can still project cached positive data as Good; Stop rethrows a faulted owner, skipping the host's session-close/reset path. Latest unit changes are not compared to the definition, and the UI drops RangeState and sample context. | C-02/C-03/C-08/C-09, AC-01/AC-02/AC-03 |
| R-04 - unsafe/incomplete presentation | Empty bar divs have no height/styles, so width alone cannot display a bar. Null percent becomes 0 and NaN can become a CSS width. Range/state/source-time presentation and accessible descriptions are incomplete. | C-01/C-02/C-03/C-04, required component section, AC-01/AC-04 |
| R-05 - unsupported completion claims | Tests and technical docs/README are unchanged; no dashboard test references exist. Only the original 207 tests are reported, with no case-specific executions. Required native smoke is unexecuted, not out of scope. | C-01..C-10, AC-05/AC-06/AC-07, shared gate |
| Original criterion | Decision | Evidence gap |
|---|---|---|
| AC-01 | NOT ACCEPTED | Some definition/number validation exists; assigned rendered states/editor and meaningful component tests do not |
| AC-02 | NOT ACCEPTED | Single loop per instance is not single owner per session; source/fault/cleanup paths are incomplete and untested |
| AC-03 | NOT VERIFIED | Source groups module reads, but no actual wire-count/v1-v2/paused-model dashboard test proves the criterion |
| AC-04 | NOT ACCEPTED | Generic dependency boundary is preserved, but real configured static/dynamic host workflow is incomplete |
| AC-05 | PARTIAL / NOT ACCEPTED | Worker reports zero-warning/error Release build and baseline 126 unit + 81 integration passes; no new dashboard tests, required native smoke NOT EXECUTED |
| AC-06 | NOT SATISFIED | No technical-document/README updates; claimed matrix/self-review lacks named assertions and executed cases |
| AC-07 | PARTIAL / NOT ACCEPTED | Prompt protection, historical reports and single-fenced report preserved; completion/coverage claims do not meet the exit contract |
The nine-project graph remains acyclic with one Client executable and independent
Components. Existing Release assemblies corroborate compilation artifacts only;
they do not independently prove test execution or dashboard behavior. The
orchestrator ran no application builds/tests/native/workload commands and did
not execute these reproductions.
Preserve the returned report unchanged. [Step-05A](Step-05A.md) requires actual
pre-fix failures for existing broken paths, completion of the already-assigned
editor/static-dynamic integration, controlled source/owner/rendering tests and
honest native evidence. If native execution is unavailable, report the exact
blocker and INCOMPLETE/BLOCKED, not PASS or an acceptance waiver.
At that review Step-06 denoted recording/replay. Its assignment was withheld.
The owner decision below now inserts display units first.
## Historical Step-05A review and focused follow-up
Decision at that review: most scope was corrected, but Step-05B was required
for the remaining existing range/test obligations. The closing review below
now accepts corrected Step-05/05A/05B. The new units request was not used as
an acceptance criterion for these completed assignments.
Reviewed [Step-05A report](Step-05A-Report.md), all dashboard/session-lifetime/
host/component changes, all new dashboard tests and existing route assertions,
technical-document/README changes, nine-project graph and existing Release
outputs. Original scope decisions:
| Area | Decision | Evidence |
|---|---|---|
| Host/editor/start/stop/live rendering | Corrected on inspected evidence | Same panel in diagnostics/simulation; actual feed discovers choices before edit; state-based actions; dispatcher subscription and rendered cycle-2 assertion |
| Single owner/session/visibility lifetime | Corrected on inspected evidence | Session-keyed shared factory, registered session resource, cancel-before-drain/disposal, direct close/scope/late-response tests and widget-independent polling |
| Fault/unit/context/presentation | Mostly corrected; range edge remains | Terminal error yields Stale/Error; cleanup continues; unit/origin changes rejected; visible safe geometry and source/time context. Uncertain branch omits range projection. |
| Tests/build/native/docs | Substantial evidence supplied; test gaps remain | Worker reports 133 unit + 91 integration passes, zero failed/skipped, clean full Release build; actual static/dynamic native workflows and final rebuilt-Client recheck; new usage/docs |
| Protected workflow/history/dependencies | Preserved on inspected evidence | Nine acyclic projects, one Client, independent Components; original assignments/reports and orchestration files retained; no dependency/system change reported |
Remaining findings, limited to existing criteria:
1. **R-01:** In
[CreateGaugeValueLocked](../src/AutoForge.Application/Features/Vehicles/Telemetry/LiveDashboard/LiveDashboardAcquisition.cs)
at that review (its pure projection was later extracted in Step-08),
Uncertain values call CreateValue without GetRangeState. CreateValue does not
derive range from that quality, so -10/1100 over 0..1000 has no low/high label.
Existing Step-05 C-02/C-03 and Step-05A R-03 require independent quality/range.
2. **R-02:** The invalid-definition test covers unit/span overflow/count but not
the full originally required C-04 bounds/precision/kind/ID/source vectors.
Non-finite geometry tests set Unknown/`--`, so they pass without exercising the
finite-percent guard. The controlled Stop-drain test releases its barrier and
session only after assertions, not in finally as the existing gate requires.
These are source/test-inspection findings; the orchestrator executed no runtime
reproduction, application build/test, native launch or workload command.
The reported 224 cases preserve the prior 207 and add seven unit plus ten
integration cases. Existing assemblies and case inventory corroborate the report,
not independent execution or missing matrix assertions.
Native evidence now explicitly covers static 850 rpm/85% bar, invalid range/unit,
editor/hide/remove/stop/restart/reset/close; actual v2 time/config/run context,
explicit stepping and paused polls not advancing physics; old routes and a
final-build static/dynamic cycle-1/close recheck. Preserve this positive evidence.
Do not redo corrected features or add conversion work to Step-05B.
## Step-05B acceptance and corrected Step-05
Decision: **ACCEPTED**, 2026-10-29. Frozen C-01..C-05 and AC-01..AC-05 are
satisfied. Step-05 with Step-05A/05B is accepted; no Step-05C is required.
Reviewed [Step-05B](Step-05B.md), its [report](Step-05B-Report.md), the focused
projection diff, actual real-provider/rendered range tests, independent invalid
definition vectors, isolated finite-percent assertions, finally/async cleanup,
documentation and existing Release/native artifacts.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Actual pre-fix Uncertain -10 expected OutOfRangeLow/actual null; shared helper now supplies range without changing quality/value; real numeric/bar low/high and exact-bound assertions |
| AC-02 | ACCEPTED | Independent invalid bounds/precision/kind/ID/label/source/unit/count vectors assert exact prior snapshot/source/Running state; Good numeric percent-only null/NaN/infinities test and actual 85% width/accessibility control |
| AC-03 | ACCEPTED | Stop-drain finally releases its barrier before awaiting cleanup; session disposal is protected on failed assertions; other new session tests use async lifetime cleanup |
| AC-04 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete nine-project Release build zero warnings/errors; 134 unit + 91 integration passes (225 total, zero failed/skipped); rebuilt native static-v1 bar/dynamics-v2 numeric baseline and close recheck |
| AC-05 | ACCEPTED | Focused projection/tests/verification-doc change and single corrective report; no future feature/dependency/project/interface/physics/wire expansion; original assignments/history preserved |
Worker self-review maps finite-value validation through independent quality/
range to actual numeric/bar consumers and safe test cleanup. Native observations
are distinguished from controlled Uncertain/invalid-input proof; no production
fault selector or fabricated native fault claim was introduced.
Source case inventory, unchanged nine-project acyclic references and existing
Release outputs corroborate the report. The orchestrator ran no application
builds/tests/native/workload commands and did not execute the reproduction.
Original Step-05 findings and its Step-05A follow-up are closed. Preserve the
207-/224-/225-case reports and original dynamics numerical/native history.
At that acceptance Step-06 was prepared for new display units, with one shared
preference/conversion contract and explicit editor/raw-data invariants. Its
returned implementation is reviewed below.
## Owner decision - imperial-default display units
The owner approves a Metric / Imperial toggle with Imperial (US) default while
keeping all internal calculations in SI. This is a new presentation requirement,
not a Step-05A defect. It must be implemented before recording/replay.
The [dated roadmap contract](ROADMAP.md) inserts the next major Step-06 for
display units and shifts only former unassigned Steps 06-20 to 07-21.
At that decision the combined recording/replay envelope became Step-07. The
prospective split below now separates recording and playback. Completed history
and original assignments/reports keep their existing numbering.
Intended display defaults: mph for normal vehicle speed (ft/s engineering option),
ft lengths, lb mass, lb/h fuel mass rate, lbf*ft torque, degF temperature and
ft/s^2 acceleration. Metric counterparts include km/h or m/s as appropriate.
RPM/volts/ratios/booleans/counts remain unchanged. Preserve source/SI values in
physics/config/wire/raw views; use one shared presentation conversion path with
explicit source versus display units. Convert gauge labels/editor bounds without
changing canonical physical bounds, quality, range or acquisition/model ownership.
First use is Imperial (US); retain an explicitly saved local choice across
navigation/restarts. Unsupported units remain explicitly unconverted, and no
fuel mass-to-volume conversion may invent density. Apply consistently across
current human-facing simulation/diagnostic/dashboard surfaces.
Following Step-05B acceptance, [Step-06](Step-06.md) assigned the two unit systems
plus Road/Engineering speed presentation, first-use/saved/error behavior, exact
conversion vectors and stable source-unit gauge bounds. Its implementation now
exists and is accepted after Step-06A below. The default and unit mappings
remain approved and unchanged.
## Historical Step-06 review and focused correction
Decision at that review: **REQUIRES FOCUSED CORRECTION / NOT ACCEPTED**, 2026-10-30.
Reviewed [Step-06](Step-06.md), its [report](Step-06-Report.md), all new conversion/
preference/native-store/presentation code, changed shell/host/editor paths,
new unit and actual-provider tests, docs, nine-project references and artifacts.
Positive evidence: exact forward/inverse mappings and rounding, Imperial/Road
default, explicit stored/corrupt/read/write states at the service boundary,
real MAUI adapter, pinned native editor behavior, 20 controlled toggles preserving
actual source/canonical/model/trace bytes and no extra reads. Worker reports
clean nine-project Release build, 178 unit + 92 integration passes (270 total,
zero failed/skipped), real native four-mode speed/range/editor/route smoke and
saved preference restoration. Existing artifacts/case inventory corroborate
that report, not independent orchestrator execution.
| Finding | Evidence | Original contract |
|---|---|---|
| R-01 - incomplete rejection boundary | TrySet calls Initialize before checking IsValid; a fresh invalid request can load/change selection/initialized state. MainLayout uses plain value/onchange for both selectors, so rejected browser selection is not bound back to the unchanged service value. Existing negative tests initialize first and test service state, not the failed control event/DOM state. | C-09, section A reject-before-any-state/store-mutation, AC-01/AC-03/AC-04 |
| R-02 - unavailable/non-numeric readout bypass | DisplayUnitPresentation echoes JsonElement.ToString for every non-number or sourceText when NumericValue is absent. Null can be blank, wrong-type numeric values are echoed as normal readings, unsupported-unit text has no notice, and callers omit source quality when projecting Unknown numerics. The gauge path handles placeholders, but diagnostics/simulation readout paths do not apply the same contract. | C-07/C-08/C-10, section C all assigned surfaces, AC-02/AC-03/AC-04 |
| Original criterion | Decision | Evidence/gap |
|---|---|---|
| AC-01 | PARTIAL / NOT ACCEPTED | Default/restoration/native storage work; fresh-invalid and failed-selector rejection are not fully atomic |
| AC-02 | PARTIAL / NOT ACCEPTED | Exact numeric vectors/inverses/rounding supported; non-numeric/unavailable paths bypass validation/notice |
| AC-03 | PARTIAL / NOT ACCEPTED | Source/bounds/draft and Good-speed toggle evidence supported; rejection and all-surface Unknown/missing outcomes remain unmet |
| AC-04 | PARTIAL / NOT ACCEPTED | Current surfaces are wired and raw data retained; primary readouts need consistent unavailable handling |
| AC-05 | WORKER EXECUTION EVIDENCE REVIEWED | Reported 270 passes/clean Release/native smoke are preservation/positive evidence; they do not prove the missing negative paths |
| AC-06 | PARTIAL / NOT ACCEPTED | Docs/report/self-review exist; C-07/C-09 claims need decisive event/readout evidence in the corrective report |
| AC-07 | PRESERVATION SUPPORTED | Original prompts/history/shared gate, nine projects/references and protected files preserved; no later step or package/system change reported |
The static-v1 contract permits null/non-numeric JSON signal values; these do
reach the diagnostics display helper. Dynamic v2 remains strictly typed and must
not be weakened to create test inputs. Valid boolean false and numeric zero must
remain distinct from unavailable readings.
The [official Blazor binding guidance](https://learn.microsoft.com/en-us/aspnet/core/blazor/components/data-binding?view=aspnetcore-10.0#use-bindgetbindset-modifiers-and-avoid-event-handlers-for-two-way-data-binding)
confirms why event-handler-only value attributes do not guarantee DOM/model
reconciliation after rejection. This is source/framework evidence, not a claim
that the orchestrator ran the failing native interaction.
No application builds/tests/native/workload commands or runtime reproductions
were executed by the orchestrator. Preserve [Step-06-Report.md](Step-06-Report.md)
unchanged. At that review Step-06A was limited to those findings and Step-07
was withheld. The closing review below accepts the corrected milestone.
## Step-06A acceptance and corrected Step-06
Decision: **ACCEPTED**, 2026-10-30. Frozen C-01..C-07 and AC-01..AC-05 are
satisfied. Step-06 with Step-06A is accepted; no Step-06B is required.
Reviewed [Step-06A](Step-06A.md), its [report](Step-06A-Report.md), the actual
guard/typed-error and get/set selector changes, shared JSON/scalar/quality
projection and callers, all new control/readout/provider/state tests, docs,
unchanged nine-project references and existing Release outputs.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Invalid proposal is checked before initialization/read/write; exact unchanged state/zero store-call assertions; both actual binding callbacks reject failed saves and recover with aligned controls/cascaded readout |
| AC-02 | ACCEPTED | Real static-v1 route and shared helper cover null/wrong type/Unknown/unsupported text/zero/false with exact source context; real-feed converted Uncertain/Stale/Stopped/unavailable projection preserves state/range/time |
| AC-03 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete nine-project Release build zero warnings/errors; 179 unit + 105 integration passes (284 total, zero failed/skipped); isolated rebuilt native default/four-mode/editor/restored-Metric/close smoke |
| AC-04 | ACCEPTED | Actual fresh-service and presentation pre-fix failures, honest framework-event versus native fault distinction, source-path self-review and aligned docs/README |
| AC-05 | ACCEPTED | Focused source/tests/docs/report scope; original assignments/reports, unit constants, defaults, source contracts, dependencies and manual workflow preserved |
No separate pre-fix native DOM failure or native storage-fault injection is
claimed. The corrected framework-supported binding plus actual callback/render
tests establish the assigned reconciliation path. Native positive behavior is
reported separately. The 14 added cases comprise one unit and 13 integration;
all 270 original cases remain in the 284-case report.
The orchestrator ran no application builds/tests/native/workload commands and
did not execute the reproductions. Source inventory, graph and existing outputs
corroborate worker evidence, not independent runtime verification.
## Prospective telemetry split and Step-07 handoff
The former combined recording/replay envelope would introduce capture ownership,
archive storage and a playback clock in one assignment. Apply the existing
bounded-scope policy before execution:
- Step-07: actual session observation capture with a bounded in-memory owner,
explicit stop/limits, source-faithful save and strict archive readback.
- Step-08: recorded playback/seek/speed feeding shared presentation, without
querying a live source or rerunning physics. Not assigned yet.
- Former unassigned Steps 08-21 become 09-22, preserving all later capability/
authorization gates and all completed numbering/history.
[Step-07](Step-07.md) freezes the capture window, loss/close/reentry outcomes,
exact count/size limits and strict archive/I/O semantics. No polling of the
200-entry UI trace, hidden new acquisition loop or display-unit data rewrite is
allowed. Recording remains in memory until explicit save after Stop; no
crash-durable/live-streaming or unlimited-duration claim is made.
The next review must not demand the deferred Step-08 playback controls.
## Historical Step-07 review and required correction
Decision at that review: **REQUIRES CORRECTION / NOT ACCEPTED**, 2026-10-30.
Reviewed [Step-07](Step-07.md), its [report](Step-07-Report.md), all observation/
capture/workspace/codec/filesystem/UI changes, actual new integration tests,
related docs/README, source lifetime registration, graph and Release artifacts.
Positive evidence includes real observations beyond the UI buffer, actual
per-operation raw/decoded association, separate capture/diagnostic/model time,
exact count/header/observation/file limits, explicit memory-only/partial states,
real file readback and native retained capture after route unmount.
Worker reports clean complete nine-project Release build and 179 unit +
124 integration passes (303 total, zero failed/skipped), preserving all 284
prior cases and adding 19 integration cases.
| Finding | Evidence | Original contract |
|---|---|---|
| R-01 - valid source observations rejected | Codec requires bytes for ProtocolError even when the real source recorded null for an empty reply. Codec uses Ordinal trace/snapshot/envelope identity comparisons where the source client accepts case-insensitive identities; a valid uppercase endpoint module can therefore fail save. | C-02/C-04/C-08, AC-01/AC-03 |
| R-02 - invalid archive boundary incomplete | Positive read.signals with signalSnapshot null calls ValidateSignalResponse before the required association check and dereferences null. Consistent edits to raw/decoded v2 values are not checked against known IDs/unit/type rules; duplicate IDs and negative model time also lack equivalent guards. | C-09, strict typed/context validation, AC-03 |
| R-03 - capture retention and failure-safe teardown | SessionTelemetryCapture.Start registers each capture with the session, but stop/discard/replacement never unregister it. DiagnosticSession retains those objects/buffers until source disposal, defeating bounded in-memory history across repeated captures. The blocking Stop test lacks finally release before observer disposal. | C-05/C-06/C-07, testing cleanup requirement, AC-02/AC-05 |
| R-04 - storage failure visibility | ListAsync returns an empty list for an existing file used as root. The panel unconditionally RefreshAsync after workspace SaveAsync catches a failure; refresh clears Error and replaces failure status with a healthy catalogue message. | C-10/C-11, AC-03/AC-04 |
| Original criterion | Decision | Evidence/gap |
|---|---|---|
| AC-01 | PARTIAL / NOT ACCEPTED | Actual observation tap/order/time/raw data is supported; valid error/case-variant captures do not all round-trip |
| AC-02 | PARTIAL / NOT ACCEPTED | Exact limits and source-close retention are supported; repeated-capture resource release and failed-assertion cleanup are not |
| AC-03 | NOT ACCEPTED | Real atomic save/readback works on tested positive paths; typed null handling/v2 semantic consistency/catalogue failure classification remain deficient |
| AC-04 | PARTIAL / NOT ACCEPTED | Native capture/save/restart/load and cross-scope retention supported; failed save errors can disappear in the actual panel flow |
| AC-05 | WORKER EXECUTION EVIDENCE REVIEWED | Reported 303 passes/clean Release/native smoke are positive preservation evidence, not proof of the untested negative paths |
| AC-06 | PARTIAL / NOT ACCEPTED | Docs/report/self-review exist; strict validation/bounded lifetime/visible I/O claims require the corrective evidence |
| AC-07 | PRESERVATION SUPPORTED | Original prompts/history/shared gate, nine projects/references and protected files preserved; no playback, package or later-step changes reported |
Native evidence separately reports static seven-operation and dynamic two-read
archives, source close/unmount retention, app restart/load/inspection and unchanged
Metric preference. The worker removed only its two named archive IDs and exact
temporary WebView profiles; its LOCALAPPDATA override did not isolate MAUI's
recordings root, and that limitation is explicitly disclosed.
The worker also reports an initial NETSDK1112 missing Windows runtime pack:
project-scoped Client restore for win-x64 resolved that genuine missing dependency,
then the required --no-restore build passed. No workload/system repair/update or
manifest/project/package change was reported or authorized by this review.
All findings above are source/test-inspection evidence. The orchestrator executed
no application build/test, native launch or failing reproduction. Preserve the
returned report unchanged. [Step-07A](Step-07A.md) consolidates the four existing
requirements; Step-08 remains blocked and no replay assignment is created.
## Historical Step-07A review and focused safe-close follow-up
Decision at that review: most scope was corrected, but Step-07B was required
for the existing R-03 safe-close overlap. The closing review below now accepts
corrected Step-07/07A/07B without redoing the supported archive/I-O fixes.
Reviewed [Step-07A](Step-07A.md), its [report](Step-07A-Report.md), all changed
source paths and new regression bodies, the shared v2 validator, resource
registration/disposal/observation lock flow, docs, graph and Release artifacts.
| Area | Decision | Evidence |
|---|---|---|
| R-01 valid-source round trips | Corrected on inspected evidence | Empty received payload now reaches protocol validation as ProtocolError/null trace bytes; source-approved case-insensitive associations preserve original data/spellings; real source/file tests |
| R-02 strict typed archive boundary | Corrected on inspected evidence | Association guard precedes dereference; shared exact v2 ID/unit/kind/finite validation, duplicate IDs and negative model time; coherent raw/decoded test edits update byte bookkeeping |
| R-03 bounded release/teardown | Normal paths corrected; close overlap remains | Deterministic stopped/limit/error resource-count assertions and finally-based barrier release; new unregister call creates the lock cycle described below |
| R-04 storage/panel errors | Corrected on inspected evidence | Missing directory versus bad file root classified; explicit boolean save outcome prevents failed-save refresh; actual panel collision/error/retry and retained catalogue tests |
| Full build/tests/native/history | Positive evidence supported | Worker reports clean complete Release build, 179 unit + 131 integration passes (310 total, zero failed/skipped), native static/dynamic save/restart/load/close and protected history |
### Remaining existing criterion: source close must not deadlock cleanup
[DiagnosticSession.DisposeAsync](../src/AutoForge.Application/Features/Vehicles/Diagnostics/DiagnosticSessionService.cs:179)
calls DisposeResourcesAsync while holding _lifetimeGate. An async method executes
its synchronous prefix immediately; that prefix calls capture.DisposeAsync and
can block in source observation unsubscription before yielding.
The protocol dispatch holds _observersGate while invoking capture callbacks.
On a limit/error stop,
[OnObservation](../src/AutoForge.Application/Features/Vehicles/Telemetry/Recording/SessionTelemetryCapture.cs:244)
now unregisters the capture through the same _lifetimeGate.
Allowed interleaving:
1. A callback owns the observer-dispatch gate and reaches failure/limit detach.
2. Source close owns the lifetime gate and starts unsubscribing/draining that callback.
3. The callback proceeds to unregister, waiting for the lifetime gate.
4. Close waits for the observer gate; neither side can finish.
This is the existing Step-07 C-05/C-06 and Step-07A R-03/C-06 safe-close contract,
not new functionality. The orchestrator identified it by source inspection;
no deadlock test or application build/test/native/workload command was executed.
Step-07B requires a controlled, safely bounded actual reproduction.
Do not resolve this by removing unregistration (restoring retained history),
weakening Stop drain, swallowing disposal errors or publishing close success
early. Preserve a single shared disposal completion and aggregate cleanup behavior.
The worker's seven added integration cases and 310-case/clean Release/native
evidence remain valid positive reports, distinct from the missing competing-close
proof at that review. All original reports remain unchanged; Step-08 was blocked
until the closing review below.
## Step-07B acceptance and corrected Step-07
Decision: **ACCEPTED**, 2026-10-30. Frozen C-01..C-05 and AC-01..AC-04 are
satisfied. Step-07 with Step-07A/07B is accepted; no Step-07C is required.
Reviewed [Step-07B](Step-07B.md), its [report](Step-07B-Report.md), the focused
source disposal change, actual protocol barrier theory and concurrent-disposal
regression, related docs/README and existing Release/native artifacts.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Actual pre-fix close/limit and reset/error lock-cycle failures; shared task/state published under gate and cleanup invoked after release; controlled operations/close/reset finish with exact frozen prefix/reason and isolated replacement |
| AC-02 | ACCEPTED | Concurrent callers get the same task and cleanup exception, controlled resource disposes once, late registration rejects; original resource/control/transport ordering and aggregation preserved |
| AC-03 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete nine-project Release build zero warnings/errors; 179 unit + 134 integration passes (313 total, zero failed/skipped); native static/dynamic unsaved retention, source close, save/restart/readback |
| AC-04 | ACCEPTED | Actual pre/post and native/control distinction, own post-green source-path review, related docs and protected/history/manual workflow preserved |
The two barrier theory cases and one concurrent-dispose case preserve the prior
310 and yield 313. The five-second deadline is a safety guard after explicit
barriers, not a probabilistic timing race. The pre-fix focused process reported
both tasks incomplete and exited with failures; no native race is claimed.
The helper records genuine cleanup success/failure in the already-published
shared completion. It does not remove unregistration, drop accepted observations,
clear required unsaved data or publish success before disposal.
The orchestrator ran no application build/test/native/workload command and did
not execute the deadlock reproduction. Graph/source/artifacts corroborate worker
execution evidence, not independent runtime verification.
Original Step-07 and both corrective findings are closed. Preserve the 303-/
310-/313-case reports and original archive/raw/source/native evidence.
[Step-08](Step-08.md) is prepared for saved-data replay with explicit
RecordedReplay context, deterministic prefix reduction and one playback owner.
No live source/session, physics execution or archive rewrite is authorized.
## Step-08 acceptance
Decision: **ACCEPTED**, 2026-10-30. Frozen C-01..C-14 and AC-01..AC-07 are
satisfied on reviewed source and worker evidence. No Step-08A is required.
Reviewed [Step-08](Step-08.md), its [report](Step-08-Report.md), all replay
models/load/owner/prefix paths, pure shared gauge extraction and live consumers,
routed UI/editor changes, all four new test partials, docs/README, graph and
existing Release outputs.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Real strict archive/file load into fresh RecordedReplay identity; no profiles/model required; failed/cancelled/stale replacement preserves previous context and close drains |
| AC-02 | ACCEPTED | Exact four-record fixture/last-Good 850 after Uncertain 1000 then Timeout; backward/ordinal/zero-time/ties/empty/non-signal/partial acknowledgement and original completion retained |
| AC-03 | ACCEPTED | Controlled 0.25x/1x/1000x waits and exact 1.7-second pause/resume; one owner, held-cleanup/reentry/generation checks, visible clock/wait/drain faults and explicit recovery |
| AC-04 | ACCEPTED | Shared definition/projection/editor/generic renderer with canonical/pinned unit bounds, actual control-event rejection and no gauge-owned clock; original/current source clearly separated |
| AC-05 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete nine-project Release build zero warnings/errors; 179 unit + 171 integration passes (350 total, zero failed/skipped), zero live/model/write counters and offline native static/dynamic final-binary replay |
| AC-06 | ACCEPTED | Executable case mapping, post-green self-review/fixes and expanded fault/coexistence tests, aligned docs with native/control/known-preparation limitations |
| AC-07 | ACCEPTED | Nine-project graph, dependency policy/Core/Diagnostics/Simulation/history/protected files preserved; no stage/commit/push/agents or subsequent work; task-owned native data cleaned |
The 37 added integration cases preserve the prior 313. Source-case inventory,
unchanged reference graph and existing artifacts corroborate worker execution;
the orchestrator ran no application builds/tests/native/workload commands.
The worker reports SDK patch 10.0.403 under the existing allowed roll-forward,
with no SDK/workload/package installation/update performed.
Native evidence includes real saved v1/v2 archives, an empty profile catalogue
after restart, four speed styles/units, exact source hashes before/after, editor
draft pinning, hide/show, pause/navigation/end/close, partial acknowledgement and
another final-binary restart. Exact timing/drain/fault proof is controlled tests,
not human-speed native observations.
The worker disclosed an unchanged recording-panel initialization error during
source preparation while a previous Save-refresh was pending. It was not called
a passing smoke or changed under replay scope. Preparation was restarted; final
replay checks passed. Track separately, do not add it to Step-09.
## Prospective calibration split and Step-09 handoff
The former calibration/programming envelope combines data authoring/versioning
with backup, approval, write/readback and recovery lifecycles. Apply the existing
bounded-scope policy before execution:
- Step-09: in-memory synthetic scalar/fixed-axis table definitions, exact
immutable configuration/module binding, baseline/proposed revisions and diffs.
- Step-10: separately verified simulated baseline/backup, approval/source/proposal
binding, write/readback/unrelated-value proof, audit and restore.
- Former unassigned Steps 10-22 become 11-23; no completed assignment/history
renumbered and no planned feature disguised as a corrective letter.
[Step-09](Step-09.md) uses explicit configuration-derived synthetic data, not an
ECU read or verified backup. Proposal validation grants no Tested/Approved/
Applied status, simulation mutation or hardware authority. No calibration disk
format/storage or programming service is assigned in this slice.
## Step-09 acceptance
Decision: **ACCEPTED**, 2026-10-30. Frozen C-01..C-12 and AC-01..AC-05 are
satisfied on reviewed source and worker evidence. No Step-09A is required.
Reviewed [Step-09](Step-09.md), its [report](Step-09-Report.md), the complete
Core applicability/definition/value contracts and Application baseline/head/
validation/version/diff flow, routed copied/pinned editor, all three new test
partials, docs/README, unchanged references and existing Release outputs.
| Criterion | Decision | Evidence |
|---|---|---|
| AC-01 | ACCEPTED | Real exact configuration/profile/module selection, model/definition identity, full scalar/table/axis/unit/bounds validation, unsupported-template and cross-source atomic rejections |
| AC-02 | ACCEPTED | Exact 650->1250/+600 and 360->350/-10 diffs, immutable parents/source/snapshots, no-op/changed-back/tiny-difference behavior, one-winner controlled stale-head commits and 32/33 capacity |
| AC-03 | ACCEPTED | Actual editor/history/diff/replacement events, parse errors/stale-editor preservation, pinned torque input units and exact unedited canonical values; authoring-only status |
| AC-04 | ACCEPTED ON WORKER EXECUTION EVIDENCE | Reported complete nine-project Release build zero warnings/errors; 179 unit + 226 integration passes (405 total, zero failed/skipped), real live/recording/replay zero-call preservation and native final-binary authoring |
| AC-05 | ACCEPTED | Executable matrix, post-green boundary/identity/defensive-copy/diff self-review additions, accurate docs and protected/history/manual workflow preserved |
The 55 added integration cases preserve all 350 prior cases. Native checks
include exact scalar/table proposals and version-pair diffs, invalid/stale-source
edits, pinned unit drafts, unchanged original configuration/live diagnostics,
explicit replacement and an empty authoring state after process restart.
They do not claim a tested/applied proposal, verified backup or ECU read.
The orchestrator ran no application build/test/native/workload command.
Case inventory, graph and existing outputs corroborate worker execution, not
independent runtime verification. SDK patch 10.0.403 remains within the existing
roll-forward policy; no dependency/system change was reported.
## Step-10 rehearsal handoff
[Step-10](Step-10.md) supplies one explicit, isolated simulation target whose
mutable supported image is owned by Simulation through a typed Diagnostics port.
It is initialized from the selected immutable configuration but thereafter read/
written independently; neither the authoring service nor a request echo is readback.
Only the supported warm-idle scalar and fixed-axis torque table are covered.
Prepare a verified process-memory supported-image backup, approve an exact
immutable proposal/source revision, compare again before dispatch, read back
fresh target state and verify every changed/unchanged value. Unknown outcomes
require explicit reconciliation; restoring the original backup requires a
separate approval bound to that same target instance and current revision.
Closing/reopening destroys/recreates the rehearsal target; old approvals/backups
cannot act on a new instance. No physical/replay target, running-dynamics mutation,
new wire/firmware format or crash-durable/device-backup claim is assigned.
Connecting the programmed image to a fresh dynamics run and functional evaluation
is later explicit work, not an implied Step-10 feature. Step-11 remains blocked.
## Prerequisites, limitations, and known issues
- Step-01A worker evidence establishes portable and native Windows compatibility
for the accepted foundation. Recheck prerequisites if the environment changes.
- No major SDK/workload/driver installation has been authorized. Report exact
missing prerequisites and mark blocked checks honestly; do not replace .NET 10
MAUI Blazor Hybrid with a web host.
- Reported workload incident: `dotnet workload restore` was mistakenly invoked
during inspection, began manifest updates and was stopped. Worker reports
workload version 10.0.403 and newer iOS/MacCatalyst manifests; Windows manifest
stayed 10.0.110. No rollback occurred. Final Windows checks passed, but broader
impact is unverified. Do not repeat workload-changing commands or repair/rollback
without explicit authorization; this review does not authorize them.
- Historical Step-01A raw `git diff --check` failed on README CRLF, against a mixed-line-ending index.
Read-only byte inspection found 151 CRLF lines and no trailing spaces/tabs.
A command-local CR-at-EOL-aware check passed, with no Git configuration changed.
Step-02 resolved working-file normalization: 149 LF and zero CRLF lines observed;
the CR-at-EOL-aware diff check passes with no global settings changed.
- Step-02 worker reports no workload-changing command was invoked; prior incident
remains historical and does not authorize future installation/update/rollback.
- Profile Step-02 R-01/R-02 remain closed and accepted; do not regress those fixes.
- Step-03 R-01/R-02/R-03/R-04 remain closed; preserve all correction invariants.
- Step-04 reference/coupling/progress/failure/UI/owner fixes are accepted with
Step-04B. Step-05's original and follow-up findings are closed. Preserve the 190-/
202-/207-case reports and original numerical/native evidence distinctly.
- Profile metadata/UI, synthetic diagnostics, deterministic dynamics/v2 and the
corrected dashboard/display units/recording archive/replay/authoring are accepted.
Simulated programming, AI and physical hardware operations
remain unimplemented.
- No application build or test has been executed by the orchestrator.
## Review and progression gate
On manual return, evaluate Step-10 and its frozen programming-rehearsal contract/shared gate using the
assignment, worker report, actual code/tests, dependency graph, Git changes,
README/docs, and recorded build/test evidence. Do not accept solely on a success
claim; do not claim independent runtime verification.
- Inspect actual isolated target state, backup/approval/source binding, rejected/
uncertain mutation and fresh readback/restore, one operation owner and zero
existing-model/source effects. Do not add deferred physics/durable/physical scope.
- If accepted: accept Step-10, update roadmap/state, prepare a bounded Step-11 local-AI/runbook assignment
and stop for manual handoff.
- If deficient: issue narrowly scoped Step-10A only for a material unmet contract/
regression, then stop. Planned new features are not corrections.
- If blocked: retain the active step, document the prerequisite and required
worker evidence; do not advance or mark unexecuted checks as successful.
- Never create the next major assignment while acceptance or corrections are open.
## History
| Date | Event | Evidence / result |
|---|---|---|
| 2026-10-28 | Initial repository inspection | Clean `main`; only root README and ignore file tracked; no application or protected instruction files found |
| 2026-10-28 | Initial roadmap, state, and Step-01 prepared | Amendment layout/naming adopted; READY FOR WORKER, no implementation accepted |
| 2026-10-28 | User returned Step-01 for review | Original assignment, worker report, code/tests, configuration, Git changes and documentation inspected |
| 2026-10-28 | Step-01 ACCEPTED | No blocking deficiency; worker evidence reports successful Release build and 54 passed, zero failed/skipped tests; no orchestrator runtime execution |
| 2026-10-28 | Step-02 prepared | Profile/module model, versioned JSON, synthetic fixtures and application selection; manual worker handoff pending |
| 2026-10-28 | Owner architecture decision superseded the dual-shell plan | One MAUI Client, UI/Components RCLs, vertical-slice modular monolith; Step-01 acceptance preserved but corrective 01A required |
| 2026-10-28 | Existing solution re-inspected | Only four headless projects; no obsolete hosts to delete; no application changes/builds/tests executed |
| 2026-10-28 | Step-01A prepared; Step-02 placed on hold | Correction is ready for manual worker execution; old Step-02 body retained, final regeneration deferred until correction acceptance |
| 2026-10-28 | Step-01A returned and ACCEPTED | Seven-project single-shell/RCL/VSA implementation inspected; worker reports successful solution/native builds, 65 passing cases and native route/asset checks |
| 2026-10-28 | Deviations recorded | Unintended workload manifest updates disclosed; no rollback; README CRLF-only diff hygiene noted for next documentation update |
| 2026-10-28 | Step-02 regenerated | Explicitly supersedes unexecuted pre-correction version; actual seven-project baseline and profile feature/UI scope; READY FOR WORKER |
| 2026-10-28 | Step-02 returned for review | Profile models/codec/catalog/UI, tests/fixtures/docs and reported 93-case/native verification inspected |
| 2026-10-28 | Step-02 requires correction | R-01 ambient-dependent timestamp parser and R-02 absent optional applicability constraints; passing reported tests do not cover them |
| 2026-10-28 | Step-02A prepared | Narrow correction with worker regressions/documentation/native checks; Step-03 blocked and not assigned |
| 2026-10-28 | Step-02A returned and ACCEPTED | Parser/constraint fixes and direct/DI/UI/native evidence reviewed; 103 unit + 37 integration passes and clean Release build reported |
| 2026-10-28 | Corrected Step-02 ACCEPTED | R-01/R-02 closed; prior 93-case and corrective 140-case reports preserved; no Step-02B |
| 2026-10-28 | Step-03 prepared | Explicit simulated sessions, virtual modules, synthetic protocol/read-clear/telemetry/trace and deterministic faults; manual handoff pending |
| 2026-10-28 | Step-03 returned for review | Nine-project protocol/provider/session/UI path and reported 161-case/native verification inspected |
| 2026-10-28 | Step-03 requires correction | Missing/ambiguous wire fields, semantic positive replies/false-positive probe trace, and clear acknowledgement treated as verification |
| 2026-10-28 | Step-03A prepared | Narrow correction with pre-fix regressions, state/trace/UI verification and documentation; Step-04 blocked |
| 2026-10-28 | Step-03A returned; scoped corrections ACCEPTED | R-01/R-02/R-03 fixed; actual pre-fix failures, clean Release build, 175-case passing run and native baseline inspected |
| 2026-10-28 | Additional Step-03 finding R-04 | Valid positive probe is discarded from responder count/service evidence when identity is unavailable; not covered by current tests |
| 2026-10-28 | Step-03B prepared | Preserve phase-specific probe/identity facts and truthful counts without relaxing identity-dependent action gates; Step-04 remains blocked |
| 2026-10-28 | Step-03B returned and ACCEPTED | R-04 closed; phase/count/guard/trace source and reported 183-case/native evidence inspected |
| 2026-10-28 | Corrected Step-03 ACCEPTED | All R-01/R-02/R-03/R-04 closed; normal and partial diagnostics, wire integrity and verified clear retained |
| 2026-10-28 | Step-04 prepared | Fixed-step coupled dynamics, explicit configuration/control and dynamic diagnostic telemetry; manual worker handoff pending |
| 2026-10-28 | Step-04 returned for review | Model/config/controller/provider/UI and reported 190-case/numerical/native evidence inspected |
| 2026-10-28 | Step-04 requires correction | Missing-reference handling, drivetrain boundary states and failed/progress/async lifecycle gaps; baseline drive cycle itself reports all numeric gates met |
| 2026-10-28 | Step-04A prepared | Narrow correctness and controlled-proof correction; Step-05 blocked and not assigned |
| 2026-10-28 | Step-04A returned for review | Reference/coupling/progress/failure/UI fixes and reported 202-case/native evidence inspected; pending owner-drain transition remains |
| 2026-10-28 | Owner requested orchestration reassessment | Prospective scope sizing, frozen contract/evidence matrices and worker self-review gate introduced; no retrospective criteria |
| 2026-10-28 | Step-04B prepared | Single existing reject-before-mutate overlap; no physics/protocol/new feature scope; Step-05 remains blocked |
| 2026-10-28 | Step-04B returned and ACCEPTED | Frozen C-01..C-05 satisfied; guard ordering, before/after status/state tests, real UI, self-review and reported 207-case/native evidence inspected |
| 2026-10-28 | Corrected Step-04 ACCEPTED | Original and 04A/04B criteria closed; source and numerical history preserved; no 04C |
| 2026-10-28 | Step-05 prepared | Bounded numeric/bar dashboard with one acquisition owner, in-memory validated bindings and frozen data/lifecycle matrix; manual handoff pending |
| 2026-10-29 | Step-05 returned and reviewed | Partial Application feed and generic gauge/diagnostic wiring; same 207 baseline passes/clean Release build reported; required native smoke not executed |
| 2026-10-29 | Step-05 requires correction | Consolidated R-01..R-05: host/editor/startup, session owner/lifetime, fault/data truth, generic rendering, missing tests/docs/native evidence; no new acceptance criteria |
| 2026-10-29 | Step-05A prepared | Complete original frozen contract and worker self-review before manual return; Step-04 remains accepted and Step-06 blocked |
| 2026-10-29 | Step-05A returned and reviewed | Real shared editor/panel/session owner, safe gauges, 17 new cases/docs and worker-reported 224-case/clean Release/native evidence inspected |
| 2026-10-29 | Focused Step-05B required | Existing Uncertain low/high independence and decisive boundary-test/finally-cleanup obligations remain; no new product scope |
| 2026-10-29 | Owner approved imperial-default display units | SI calculations unchanged; global metric/Imperial (US) preference and conversions must precede recording/replay; not a Step-05A acceptance change |
| 2026-10-29 | Future numbering updated | Display units inserted as unassigned Step-06; former unassigned 06-20 become 07-21; completed assignments/history preserved |
| 2026-10-29 | Step-05B prepared | Narrow range/test correction only; next major handoff is units after dashboard acceptance, not recording/replay |
| 2026-10-29 | Step-05B returned and ACCEPTED | Frozen range/test/cleanup matrix satisfied; actual red regression, 225-case/clean Release/native recheck evidence and source-path self-review inspected |
| 2026-10-29 | Corrected Step-05 ACCEPTED | Original and 05A/05B criteria closed; no 05C; reports/source/numerical history preserved |
| 2026-10-29 | Step-06 prepared | Imperial-default shared presentation preference/conversions, stable canonical source bounds and explicit editor/raw-data policy; manual handoff pending, Step-07 blocked |
| 2026-10-30 | Step-06 returned and reviewed | Exact conversion/default/native persistence/editor/source-invariance paths and reported 270-case/clean Release/native evidence inspected |
| 2026-10-30 | Step-06 requires focused correction | R-01 fresh-invalid initialization and failed-selector reconciliation; R-02 null/non-numeric/Unknown display bypass; original C-07/C-08/C-09, not new product scope |
| 2026-10-30 | Step-06A prepared | Narrow rejection/readout correction with real pre-fix/event/provider tests; preserve approved imperial defaults/mappings, no Step-07 |
| 2026-10-30 | Step-06A returned and ACCEPTED | Frozen rejection/readout contract satisfied; actual regressions, binding callbacks, real provider/readout states and reported 284-case/clean Release/isolated native evidence inspected |
| 2026-10-30 | Corrected Step-06 ACCEPTED | Original and 06A criteria closed; Imperial default/metric options/source invariants preserved; no 06B |
| 2026-10-30 | Telemetry envelope split prospectively | Step-07 bounded recording/archive, Step-08 replay; former unassigned 08-21 become 09-22; no completed history renumbered |
| 2026-10-30 | Step-07 prepared | Single capture-owner outcome, strict source-faithful archive/readback and explicit limits; no playback clock, manual handoff pending |
| 2026-10-30 | Step-07 returned and reviewed | Real observer/capture/archive/UI implementation and reported 303-case/clean Release/native save/restart/readback/unmount evidence inspected |
| 2026-10-30 | Step-07 requires correction | Four original-scope findings: valid-source round trips, typed/strict archive semantics, released-capture retention/test cleanup, and catalogue/panel I/O visibility |
| 2026-10-30 | Step-07A prepared | Consolidated corrective matrix with real pre-fix/negative/lifecycle/panel evidence; prior recording/unit/source behavior preserved and replay blocked |
| 2026-10-30 | Step-07A returned and reviewed | Archive/I-O/normal unregistration fixes and reported 310-case/clean Release/native evidence inspected; most corrective scope supported |
| 2026-10-30 | Existing R-03 close-overlap remains | Lifetime gate held during synchronous disposal prefix can wait for observer callback that needs the lifetime gate to unregister |
| 2026-10-30 | Step-07B prepared | Single lock-order/safe-close correction with controlled reproduction and preserved disposal/data semantics; replay remains blocked |
| 2026-10-30 | Step-07B returned and ACCEPTED | Actual pre-fix close/reset deadlocks, corrected gate/task ordering, preserved prefix and shared cleanup-failure assertions plus reported 313-case/clean Release/native evidence inspected |
| 2026-10-30 | Corrected Step-07 ACCEPTED | Original and 07A/07B criteria closed; source archive/limits/storage/default-unit behavior preserved; no 07C |
| 2026-10-30 | Step-08 prepared | Saved validated archive, explicit RecordedReplay context, prefix-correct gauges/seek and one cancellable clock; manual handoff pending, calibration blocked |
| 2026-10-30 | Step-08 returned and ACCEPTED | Frozen replay contract satisfied; reported 350-case/clean Release/offline native evidence, exact prefixes/time/owner/source/units and self-review inspected; no 08A |
| 2026-10-30 | Calibration envelope split prospectively | Step-09 authoring/versioning/diffs, Step-10 simulated programming; former unassigned 10-22 become 11-23; completed history preserved |
| 2026-10-30 | Step-09 prepared | Configuration-derived synthetic baseline, immutable scalar/table proposals and exact diffs; no model mutation, approval/backup/programming or physical writes |
| 2026-10-30 | Step-09 returned and ACCEPTED | Frozen authoring contract satisfied; reported 405-case/clean Release/native evidence, exact source/head/versions/diffs/limits/no-write and self-review inspected; no 09A |
| 2026-10-30 | Step-10 prepared | Isolated typed simulation target, verified volatile supported-image backup, approval/CAS/write/fresh readback/reconciliation/restore; no existing-model or physical writes, no renumbering |
## Manual handoff instruction
Provide [Step-10.md](Step-10.md) and the shared
[worker gate](WORKER-QUALITY-GATE.md) to the separate worker and request execution
of that assignment only. The worker must produce `prompts/Step-10-Report.md`
and stop for review. Do not begin Step-11 local AI/runbooks.
Return manually to the orchestrator for review. Reports, including final chat
reports, must follow the single plain triple-backtick copy-window requirement.