Cubase-MCP-GAJ3T.MusicGen.R.../prompts/report_3.md

204 lines
13 KiB
Markdown

```
STEP 3 REPORT — Instrument-neutral composition and deterministic text planning
Date: 2026-10-19
Step 3 readiness: TRUE — implemented and verified; ready for orchestrator review.
Ready to satisfy Step 4 production exit criteria: FALSE — real mapping evidence
is still absent. Acceptance of Step 3 does not close that evidence gate.
IMPLEMENTED
- Wrote docs\text-description-contract.md before implementing the parser.
It explicitly defines the bounded English grammar, supported paraphrases,
defaults, role/subset semantics, timing convention, numeric/resource limits
and unsupported instructions. README now describes the in-process API and
distinguishes composition planning from public MCP generation.
- Added dependency-free Core composition models: global BPM, typed meter/key/
mode, bars, role tracks, absolute pitched notes, logical drum hits, typed
articulation intentions, immutable collection snapshots and applied defaults.
No production profile IDs, playable ranges, channels, vendor switch values
or guessed SD3 MIDI pitches were introduced.
- Added normalized immutable signed-Int64 BeatFraction quarter-note timing.
Default zero is 0/1; denominators must be positive. Arithmetic/comparison
uses checked Int128 intermediates and checked normalized Int64 results.
Conversion to 960 PPQ ticks is exact or fails; no floating-point beat drift.
- Added explicit settings/model validation: positive finite SMF-representable
tempo, meter fields and denominator-beat representability, positive bars,
normalized key/mode, distinct selected roles, nonempty tracks, correct event
kinds, pitch 0..127, sounding velocity 1..127, typed articulation/drum voice,
nonnegative starts, positive durations, exact timing and full event extent.
Declared extent remains all bars even with trailing rests.
- Added parser/planning failure results with stable codes, fields, actionable
messages and offending text where applicable. Failures expose no partial
usable description/composition. Meaningful unconsumed text is rejected.
Expected arithmetic/representability catches are confined to timing/count
preflight and validation, not arbitrary exceptions or fallback-to-defaults.
- Added deterministic root quarter/eighth/sixteenth and full-bar sustained
pitched patterns, explicit kick/snare denominator-beat placement and closed
hi-hat subdivisions. Track ordering and simultaneous hit ordering are stable.
All pattern counts and extent are checked before expanding event lists.
- IntegrationTests now directly references Core. Its existing apphost-copy
target explicitly queries only Server, preventing the added reference from
contaminating server-output discovery. Refreshed its generated lock file.
No new package or package-version change was necessary.
- Retained all previous protocol/scaffold/process tests. No Server production
source changed: its real MCP registry remains empty. Full retained real-
process tests verify that behavior alongside the new in-process pipeline.
GRAMMAR, DEFAULTS AND LIMIT DECISIONS
- Accepted settings: unsigned ASCII integer BPM; positive Int32 bars (also
one through sixteen in words); numerator/denominator meter; A..G roots with
optional #/b/Unicode sharp/flat and major/minor mode.
- Role aliases: lead guitar/lead/guitar, bass, drums. Supported pitched
modifiers are sustain/palm-muted/palm mute, root-note subdivisions and
sustained roots. Hyphen/space variants, case, whitespace and ordinary
clause punctuation are documented. Modifiers bind to their own role.
- Repeated identical clauses/settings deduplicate; conflicting duplicates,
duplicate beat positions, malformed numbers, unsupported articulations,
genres, chords, tuning, arbitrary melody/dynamics and unknown words fail.
- Defaults: 120 BPM, four bars, 4/4, E minor; lead root octave 4 (C4=60),
bass root octave 2 (C2=36), velocity 96 and sustain articulation.
Enharmonics normalize before selecting the octave: E gives lead 64/bass 40,
B# gives C4/C2, Cb gives B4/B2. These are musical choices, not mappings.
- If no role or drum part is mentioned, select all three. Otherwise select
only explicit roles. Lead defaults to root eighth notes; bass defaults to
one full-bar root note per bar.
- Bare drums in 4/4 defaults to kick 1/3, snare 2/4, eighth-note closed hi-hat.
Any explicit drum part selects only supplied parts, including with a bare
drums clause; no omitted drum part is silently added. Non-4/4 drums require
explicit parts. Every applied default has a field and value; defaults for
unselected roles/omitted subset parts are not applied.
- Meter numerator: 1..255. Denominator: power of two, 1..256, so the human
denominator-note beat is exactly representable at 960 PPQ. In 3/8, beat 2
is 480 ticks after the bar start, not 960. Bar length is numerator*4/
denominator quarter notes. Subdivisions must divide the whole bar exactly.
- SMF tempo requires 60,000,000/BPM in 1..16,777,215 microseconds per quarter;
nearest-integer rounding, midpoint away from zero, is documented for future
encoding. Requested BPM remains unchanged in the composition.
- Fixed internal limit: 100,000 generated notes plus logical hits combined.
Exactly 100,000 passes; 100,001 fails with event_limit_exceeded before
pattern expansion. No public override or truncation. Description text is
bounded to 16,384 UTF-16 characters. Checked counts use Int64.
ACCEPTANCE EXAMPLE AND TEST EVIDENCE
- The exact plan description produces all three tracks, four bars at 120 BPM
in E minor, 4/4, zero planning lead-in, extent 16 quarter notes/15,360 ticks.
- Lead: 32 E4/MIDI-64 palm-mute notes, starts every 480 ticks, duration 480.
Bass: four E2/MIDI-40 sustain notes, starts every 3,840 ticks, duration 3,840.
Kick: eight hits on beats 1/3; snare: eight on beats 2/4; closed hi-hat:
32 eighth-note hits. All bar starts and durations are checked exactly.
- Tests cover normalization, arithmetic/comparison, exact and fractional ticks,
invalid denominators, wide intermediates and checked overflow; complete
acceptance values/defaults; paraphrases; enharmonic normalization; role-local
modifiers; explicit-only roles/drum subsets; defaults and repeated settings;
rejection of malformed/meaningful leftover instructions; numeric ranges,
event-kind/role validation, complete extents and trailing rests.
- Long repeated pitched and hi-hat patterns verify absence of drift. Non-4/4
tests verify denominator beats and reject inappropriate default/subdivision
assumptions. Exact event boundaries cover pitched, drums and combined roles;
the combined 100,001 case and Int32.MaxValue bar requests reject pre-expansion.
- Repeated calls and reused parsed descriptions are structurally identical.
Collections are read-only snapshots; source-list mutations and attempts to
mutate results cannot affect another result.
- Ten new integration cases exercise real Core parser -> planner -> validator
in-process, including the complete example, role subsets, 3/8 and failures.
These are not final public MCP generation/file-writing integration claims.
CHANGED FILES (22 deliverables, including this report)
README.md
docs\text-description-contract.md
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\BeatFraction.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\Composition.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\TrackPlan.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\MusicalNote.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\DrumHit.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\MusicalTypes.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\ParsedDescription.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\CompositionDiagnostic.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\CompositionPlanningResult.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\CompositionValidator.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\DescriptionParser.cs
src\GAJ3T.MusicGen.RiffGrooveBuilder.Core\Composition\CompositionPlanner.cs
tests\GAJ3T.MusicGen.RiffGrooveBuilder.UnitTests\Composition\BeatFractionTests.cs
tests\GAJ3T.MusicGen.RiffGrooveBuilder.UnitTests\Composition\CompositionValidatorTests.cs
tests\GAJ3T.MusicGen.RiffGrooveBuilder.UnitTests\Composition\DescriptionParserTests.cs
tests\GAJ3T.MusicGen.RiffGrooveBuilder.UnitTests\Composition\CompositionPlannerTests.cs
tests\GAJ3T.MusicGen.RiffGrooveBuilder.IntegrationTests\Composition\CompositionPipelineTests.cs
tests\GAJ3T.MusicGen.RiffGrooveBuilder.IntegrationTests\GAJ3T.MusicGen.RiffGrooveBuilder.IntegrationTests.csproj
tests\GAJ3T.MusicGen.RiffGrooveBuilder.IntegrationTests\packages.lock.json
prompts\report_3.md
EXACT VALIDATION COMMANDS AND RESULTS
All dotnet commands ran from the repository root with process-local settings:
$env:PATH = 'C:\Program Files\dotnet;' + $env:PATH
$env:DOTNET_CLI_TELEMETRY_OPTOUT = '1'
$env:DOTNET_NOLOGO = '1'
This uses the installed C:\Program Files\dotnet\dotnet.exe without machine
configuration changes.
1. dotnet restore .\GAJ3T.MusicGen.RiffGrooveBuilder.slnx
PASS, exit 0. All five projects restored after the project-reference edit.
Only IntegrationTests' generated lock needed the direct Core project entry.
2. dotnet test .\GAJ3T.MusicGen.RiffGrooveBuilder.slnx -c Release --no-restore --filter FullyQualifiedName~Composition
Development run 1: exit 1.
UnitTests: 176 passed / 1 failed / 0 skipped.
IntegrationTests: 9 passed / 1 failed / 0 skipped.
Both failures were incorrect new assertions: the 3/8 two-bar example has
12 hits (4 kick + 2 snare + 6 hi-hat), not 10; fractional numbered-beat
text correctly returned invalid_number rather than unsupported_text.
Corrected the assertions without permitting fractional beats or dropping
any musical events.
Development run 2: PASS, exit 0.
UnitTests: 177 passed / 0 failed / 0 skipped.
IntegrationTests: 10 passed / 0 failed / 0 skipped.
Added the combined-role 100,001-event regression before final validation.
FINAL REQUIRED ACCEPTANCE COMMANDS
3. dotnet build .\GAJ3T.MusicGen.RiffGrooveBuilder.slnx -c Release --no-restore
PASS, exit 0. All five projects built. 0 warnings, 0 errors.
4. dotnet test .\GAJ3T.MusicGen.RiffGrooveBuilder.slnx -c Release --no-build
PASS, exit 0. Both test assemblies discovered and executed:
UnitTests: 294 passed, 0 failed, 0 skipped (708 ms).
178 new composition cases + all 116 retained baseline cases.
IntegrationTests: 24 passed, 0 failed, 0 skipped (977 ms).
10 new Core pipeline cases + all 14 retained real-process cases.
TOTAL: 318 passed, 0 failed, 0 skipped.
188 new cases + all 130 prior cases.
5. dotnet restore .\GAJ3T.MusicGen.RiffGrooveBuilder.slnx --locked-mode
PASS, exit 0. All five projects restored using generated locks.
ADDITIONAL CHECKS
- Editor runTests over the five new test files reported "No tests found".
Used the already-approved CLI fallback; no empty editor discovery was
misreported as a passing test run.
- Final editor problems check over src/tests: no errors found.
- git --no-pager diff --check: PASS, exit 0.
- In-memory PowerShell trailing-whitespace audit: PASS, exit 0; all 21
Step 3 deliverables preceding this report checked, excluding bin/obj.
- Core project XML audit: PASS, exit 0; no package or project references.
- SHA256 preservation audit: PASS, exit 0; plan.md, step_1.md, step_2.md,
step_3.md, report_1.md and report_2.md unchanged from worker entry.
The pre-existing modified plan was preserved, not reset or edited.
ISSUES, UNRUN CHECKS AND READINESS
- The two development assertion issues are resolved. No unresolved Step 3
implementation/test blocker remains. Step 3 is ready for review, not an
authorization to proceed beyond its scope.
- No native/plugin/Cubase imports, MIDI/native output checks, self-contained
publication or public generation-tool integration were run: those require
later steps and/or unavailable authorized production evidence.
- Step 4 evidence remains ABSENT: exact installed product versions/settings,
verified Eclips/Ray playable/articulation/keyswitch/CC/velocity/timing/state/
channel rules, and the actual SD3 library/drum map have not been supplied.
Native schemas, confirmed AGP/SDP semantics, lawful fixtures/template rights
and successful target-application import evidence also remain unverified.
Musical pitch defaults/logical drum voices do not establish any of these.
Step 4 production mapping exit criteria cannot be declared ready; obtain
evidence/owner direction rather than fabricate profiles or mappings.
- Core remains independent of DryWetMIDI. Production MCP tools remain empty.
No new packages, future-step implementation, orchestrator prompt/plan edits,
commits, delegation or scratch artifacts were introduced.
- Stopping after this report.
```