205 lines
12 KiB
Markdown
205 lines
12 KiB
Markdown
```
|
|
Step 15 correction — COMPLETE and verified; READY for Step16 review
|
|
Date: 2026-10-20
|
|
|
|
AUTHORITATIVE CORRECTION / HISTORY
|
|
Read step_15_fix.md, step_15.md, report14/15 and the accepted current
|
|
pitch/strict-plan/composer/description/service/native/transport foundation.
|
|
The canonical native chord is D3=[50,54,57], NOT D2=[38,42,45].
|
|
No tuning, native validator, user-explicit pitch, profile or fallback rule was
|
|
changed to make a physically impossible chord appear native.
|
|
report_15.md is preserved unchanged as historical blocked-attempt evidence;
|
|
its unsupported-parser/readiness statements are superseded by this report.
|
|
Historical report15 SHA256:
|
|
812c33ef2c1e6279cedaa7f769dfff385dad1ef680b06afb1839d318bab9b8b1
|
|
|
|
IMPLEMENTED PUBLIC PATH
|
|
generate_music.description now actually accepts hybrid prose and precise
|
|
Counts/Events/Notes/Chords lanes, through the real source and installed tool.
|
|
No resolver injection, whole-example recognition or canned music branch.
|
|
|
|
Added hybrid.py:
|
|
- Separate recognized lane/hold clauses before the legacy prose sequence
|
|
guard. Unknown remainder still goes through the closed context grammar.
|
|
- Reusable count_grid uses exact Fraction quarter-beat timing, with numeric
|
|
labels counting meter-denominator units, never visual width.
|
|
- Typed unresolved HybridSlot/HybridPlan in schemas preserve exact positions
|
|
while selected-profile pitch resolution waits for routing.
|
|
- materialize reuses Step14 tokenize_notation/parse_pitch/parse_chord/
|
|
resolve_voicing and creates the existing ExplicitAttackPlan.
|
|
- description and compose/service reuse that one parser/materializer without
|
|
introducing circular dependencies or a duplicate voicing engine.
|
|
- Existing compose/compiler, profile articulation resolution, MIDI/native
|
|
codecs, independent readers, CC budgets and atomic publication remain in use.
|
|
|
|
Service results add default-empty resolved.interpretation for compatibility.
|
|
Each hybrid attack exposes resolved MIDI pitch sets, exact rational start/
|
|
duration, technique, part, optional intensity and held status. Assumptions
|
|
disclose root/bass/default pitch resolution, no-key-retuning and seed policy.
|
|
Complete text JSON equals structuredContent, including interpretation and
|
|
errors. Guidance advertises bounded actual support rather than arbitrary
|
|
natural-language rhythm understanding. README/architecture/compatibility
|
|
document supported grammar and the corrected D3 versus explicit D2 policy.
|
|
|
|
GRAMMAR / POLICIES / LIMITS
|
|
- Case-insensitive row labels, normal whitespace/tabs, compact pitch/event
|
|
runs, ordered Bar/Measure N headers or matching | boundaries.
|
|
Notes/Chords are independently optional; Counts/Events required per bar.
|
|
Present rows must match exact slot counts and bar spans; never zip-truncate.
|
|
- Complete 1& = eighths; 1 E & A = sixteenths; [4 trip let] = three explicit
|
|
eighth-triplet positions. Bare N is one full denominator beat.
|
|
Grid:/Subdivision: eighths, sixteenths, eighth-triplets are supported.
|
|
Bare 1&a is ambiguous without an explicit sixteenth/triplet grid.
|
|
Sixteenth-grid 1&a explicitly omits e: starts0,1/2,3/4, lengths1/2,1/4,1/4.
|
|
Triplet-grid 1&a starts0,1/3,2/3. No inferred triplet from three attacks.
|
|
Tested 3/4, 4/4 and denominator2/4/8/16 math, no compound-grouping claim.
|
|
- o=normal/open articulation (not fingering), x=PM, ^=evidenced AME lead PH,
|
|
-=rest, ~=adjacent prior sound extension with no retrigger. A rest truly
|
|
ends sound; continuation after silence/new pitch fails. PH ties preserve PH.
|
|
Events / and backslash give a specific reserved-slide origin/destination/
|
|
timing error, never a silently ordinary attack or slash-chord confusion.
|
|
- Uppercase pitch letters A-G, ASCII #/b, optional signed octave; C4=60.
|
|
Major, m/min, (add4), root octaves, / and Over bass and explicit voicings
|
|
use the accepted Step14 rules. Chords:[C3 E3 G3] is simultaneous, whereas
|
|
Notes/Events brackets group consecutive slots. Compact lane dashes work
|
|
before/after/between pitch atoms without losing signed-octave semantics.
|
|
Em4OverB2 and Em4/B2=[47,64,67,71]; Em4/B and Em4OverB=[59,64,67,71].
|
|
Default octaves are disclosed; explicit bass must already be lowest.
|
|
- One selected pitched part. At most one sounding pitch source per slot.
|
|
A genuinely unspecified attack uses the disclosed low-tonic context default;
|
|
an explicit source is never overwritten. Key/style never alter exact tones.
|
|
- Hold/Tie the final note/chord/G4/E2 through/to the end of bar/measure2,
|
|
optionally without retriggering; Bar2 hold previous note to bar end; or
|
|
all-tilde continuation rows extend one original attack/chord.
|
|
Pitch mismatch, target0/out-of-range, rests or new attacks in a held span,
|
|
nonadjacent ties and shorter-bar/incompatible-meter overrides fail.
|
|
- Global techniques and direct prose pitch claims must agree with exact
|
|
lanes. Bounded first-PM-then-PH prose is not mistaken for an accidental
|
|
global conflict. Extra contradictory technique claims still fail.
|
|
Low-register chord voicings, aggressive/tight metal style and bounded
|
|
velocity variation are context, not permission to change precise music.
|
|
Existing seed intensity policy: one draw per attack shared by chord tones.
|
|
- 4000-character public input bound, strict typed plans, exact compiler grid,
|
|
expanded tone-plus-articulation event budget and existing explicit-CC
|
|
combined budget. No unrequested CC/effects, arbitrary prose, new drum-lane
|
|
language, hidden revoice, dropped tone, transpose or plugin/DAW claim.
|
|
Malformed/unknown material returns static authored private-safe errors.
|
|
Prose-only requests remain on the old paths with old safeguards and bytes.
|
|
|
|
ACTUAL SOURCE AND INSTALLED NATIVE/MIDI READ-BACK
|
|
Both transports used the PUBLIC tool with allow_midi_fallback=false for D3.
|
|
Both returned complete with .mid and .griff, no fallback_for target, no CC.
|
|
Independent Mido/XML readers checked every tone, onset, duration, velocity,
|
|
articulation, native string/fret/tuning and occupied-string nonoverlap.
|
|
|
|
Corrected canonical, MIDI960 starts/ends:
|
|
0 / 480 [42,46,49] PM
|
|
480 / 960 [42,46,49] PM
|
|
960 / 1440 [50,54,57] PM
|
|
1440 / 1920 [50,54,57] PM
|
|
1920 / 2400 [46,50,53] PM
|
|
2400 / 2880 [46,50,53] PM
|
|
2880 / 3200 [60] PM
|
|
3200 / 3520 [64] PM
|
|
3520 / 7680 [67] PH, no bar2 retrigger
|
|
Nine attacks, exactly21 musical note-ons,21 native Note elements.
|
|
Native480 times are exactly half these MIDI times.
|
|
D3 legal assignments: MIDI50 string4/fret2,54 string3/fret1,57 string2/fret0.
|
|
F#2:42 string6/fret6,46 string5/fret3,49 string4/fret1.
|
|
Bb2:46 string5/fret3,50 string4/fret2,53 string3/fret0.
|
|
C4 string2/fret3; E4 string1/fret2; G4 string1/fret5.
|
|
MIDI selector-ons (tick,pitch)=(0,26),(3520,31), velocity100,30-tick gates.
|
|
46 scheduled note events including selectors; no controllers/program changes.
|
|
Final G4 start11/3, duration13/3 quarter beats, held=true in interpretation.
|
|
Source/installed/compact bytes agree:
|
|
mid SHA256:
|
|
6fd027fe4f74fec953be4c31fecda8eb14dec9bae0d15f76ae0c3dc481fdd181
|
|
griff SHA256:
|
|
45084055f11997d4f046f58190a08856bdb5e9de7d647a62227213a9994b6f1f
|
|
|
|
HONEST OLD D2 NEGATIVE-NATIVE / POSITIVE-EXACT-MIDI
|
|
Both real transports also used the original explicit D2 row unchanged.
|
|
allow_midi_fallback=false:
|
|
NATIVE_FORMAT_UNAVAILABLE, no_physical_string_assignment, no publication.
|
|
allow_midi_fallback=true:
|
|
midi_fallback, exactly one .mid, explicit native-unavailability warning,
|
|
fallback_for=[lead], all21 musical tones preserved including both38/42/45
|
|
chord sets at960/1440. No .griff, dropped tone or hidden D3 transposition.
|
|
Both fallback MIDIs are byte-identical to report15's independently proven MIDI:
|
|
4ce995ca751590b32cd85c72c3a2d8dad7f478cdf34d3abb12616d121719c3b4
|
|
|
|
ORIGINAL E2 TWO-MEASURE PHRASE UNCHANGED
|
|
Both transports verified hybrid E2, all-tilde bar2 and continuation-clause
|
|
bar2 against the accepted original nine-note source/installed byte hashes.
|
|
All four spellings preserve nine MIDI40 notes and nine native notes:
|
|
starts:0,480,960,1440,1920,2400,2880,3200,3520
|
|
ends:480,960,1440,1920,2400,2880,3200,3520,7680
|
|
velocities:80,80,64,80,96,80,80,80,80
|
|
PM26 at0,PH31 at3520; no bar2 retrigger, no CC.
|
|
mid SHA256:
|
|
c1967e698a50b8c22a22e458c3e2dd02d04407d1ad1d61f8a462d790b0810e62
|
|
griff SHA256:
|
|
e8195e74c60ac93b1a4c92967a0834a64b2a2ebd74f453d6d3640ea465c4104c
|
|
The existing verbatim original prose source/installed tests also remain active.
|
|
|
|
OTHER LIVE PUBLIC ACCEPTANCE
|
|
Source AND built/installed-wheel transports independently verified slash/Over
|
|
aliases and both bass-octave policies, [C3 E3 G3], Em4(add4), default F# with
|
|
visible root assumptions, and out-of-key exact tones. They checked the real
|
|
rest-separated E2 attacks and adjacent tilde extension, plus compact canonical
|
|
bytes. Invalid row mismatch, ambiguous1&a, slide, conflicting hold, private
|
|
unknown prose and disabled D2 fallback published no artifacts/staging remnants.
|
|
All successes/failures preserved text JSON/structuredContent/schema parity.
|
|
Installed bootstrap verified hybrid/pitch modules came from the installed
|
|
noneditable wheel, not src. Test-only distributions were built offline from
|
|
sdist and installed outside the checkout; dist release files were not refreshed.
|
|
|
|
VALIDATION / ISSUES ENCOUNTERED
|
|
All commands use .\.venv\Scripts\python.exe.
|
|
Focused new unit/source/installed-distribution acceptance:
|
|
-m pytest -q tests\unit\test_hybrid.py
|
|
tests\integration\test_hybrid_stdio.py
|
|
tests\integration\test_distribution.py --tb=short
|
|
PASS127 in16.57s after the final PM/PH alias case and formatting.
|
|
First full-suite run:1781 passed,1 failed in69.31s.
|
|
The sole failure was the new documentation link to this not-yet-written
|
|
report, not music/parser/native behavior. This file resolves that link.
|
|
Earlier focused failures were test harness assumptions about the old installed
|
|
module count and exact legacy guidance wording; updated module count to include
|
|
hybrid/pitch and retained compatible, more precise guidance. Both now pass.
|
|
Strict typing annotations and one overlong test string were corrected.
|
|
No new technical/music blocker remains.
|
|
Final full-suite result:
|
|
-m pytest -q --tb=short:
|
|
PASS1785 in68.66s, including real source and installed-wheel public hybrid
|
|
native/MIDI, original phrase, all previous native/template/CC/privacy/
|
|
atomic/strict-plan/pitch regressions and documentation links.
|
|
The only subsequent code-tree change was formatting one test expression;
|
|
focused127 and all static checks passed again on that final tree.
|
|
Latest static checks:
|
|
-m ruff check .: PASS, all checks passed.
|
|
-m ruff format --check .: PASS,107 files already formatted.
|
|
-m mypy --strict src tests: PASS,57 source files.
|
|
-m pip check: PASS, no broken requirements.
|
|
git diff --check: PASS.
|
|
Editor problems: no diagnostics in changed parser/schema/description/service.
|
|
|
|
PERSISTENCE / PRESERVATION / NEXT STEP
|
|
Persistent independent numeric evidence, interpretation, SHA256 hashes and
|
|
actual copied MIDI/.griff files are retained at:
|
|
.test-artifacts\step15-fix\source\evidence.json
|
|
.test-artifacts\step15-fix\installed-wheel\evidence.json
|
|
.test-artifacts\step15-fix\<source|installed-wheel>\hybrid-*
|
|
These survive cleanup of per-test subprocess/distribution scratch workspaces.
|
|
Pre-existing accepted dirty changes were preserved. No version, dependency,
|
|
tuning, native codec, compiler, application configuration or release artifact
|
|
changes; no dependency installation beyond existing offline test-wheel
|
|
acceptance; no commits, delegation, later prompts or user-app operations.
|
|
|
|
Step16 readiness: READY for review and the next authorized step.
|
|
All requested software gates passed; no new precise technical blocker remains.
|
|
Version remains0.1.1; final release/version work belongs to Step16.
|
|
Do not mistake historical report15 for the current supported public contract.
|
|
No next prompt was created.
|
|
```
|